fix: disable preview for custom app#59
Open
null-crafter wants to merge 2 commits into
Open
Conversation
Code Quality Review
SummarySmall, focused fix that disables preview mode for custom-app embeds. Logic is correct and the accompanying test coverage targets the new query param behavior directly. |
UI/UX Review
SummaryFocused, low-risk 3-line fix that correctly bypasses preview mode for custom app integrations. No visual or accessibility regressions. Main UX risk is silent fallback when the query param is mistyped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Changes
Disable preview mode for custom app (having
custom-app=truein query param). This enables external app devs to chat with mentors