Skip to content

Refactor of all collection Types. #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Dandielo wants to merge 39 commits into
base: master
Choose a base branch
from
Open

Refactor of all collection Types. #202

Dandielo wants to merge 39 commits into from

Conversation

@Dandielo
Copy link
Member

@Dandielo Dandielo commented Jan 4, 2026 •
edited
Loading

Finished changes:

  • Removed 'ucount'

WIP changes:

  • u: String
  • u: VarString
  • u: HeapString (AllocString)
  • u: HeapVarString (AllocVarString)
  • u: StaticString
  • n: ncount
  • n: nindex

Remaining changes:

  • View
  • Span
  • Array
  • HashMap (u64 key)
  • RBMap (any key)
  • Queue
  • Others?

@Dandielo Dandielo self-assigned this Jan 4, 2026
@Dandielo Dandielo added feature Request for a new feature or functionality tech-debt Technical debt that needs to be addressed, but can be tolerated for some time enhancement Improvements or additions to code labels Jan 4, 2026
Dandielo added 23 commits January 4, 2026 23:23
@Dandielo
Removal of old includes.
1a5677e
@Dandielo
Refactor 'ncount_base<>' into 'nvalue'. Optimized the generated asemb…
4f67fb7 
…ly of the 'nvalue' type. Improved the inital API shared across 'ncount' and 'nindex'. More to come.
@Dandielo
Final implementation of the 'nvalue' and derived types.
a2f17f4 
#ICE-204 comment Additional functionality might be added later.
@Dandielo
#ICE-205 State In Progress
d0ae2f0 
Proof of concept on defining container operations using C++ concepts and mixin types.
@Dandielo
#ICE-204
a0783db 
Added new 'min_value_or' method and optimized the equality operator.
#ICE-203
Added user postifx operators '_count' and '_index'. Fixed minor issues.
@Dandielo
(#ICE-205, #ICE-206) State In Progress
ab2adde 
Finished a working example of the 'Span' type being based on a 'ContiguousContainer' mixin.
@Dandielo
#ICE-206 Work Type Refactor
bddb60c 
(#ICE-203, #ICE-204, #ICE-205, #ICE-206)
Required changes after initial refactor of the 'Span' type.
@Dandielo
#ICE-206 State In Review
15c9b95 
#ICE-205
Added support for iterator functionality.
@Dandielo
#ICE-206
7c39447 
Fixing all code locations affected by the api change of 'Span'.
@Dandielo
#ICE-205
eb0c662 
Split out a "BasicContainer" concept from "ContiguousContainer" and improved utilities for using concepts and deducing this implementations.
#ICE-207 State In Progress
Started work on refactoring the Array container.
@Dandielo
#ICE-207
bf7eb6a 
Changes to engine source code after initial refactor of the Array type.
@Dandielo
#ICE-207
e0b9b02 
Continued work on the Array type. Almost finished the refactor.
#ICE-205
Added 'clear' to the requirements of a 'Resizable' container.
In addition, any operations that change the contents are better to be part of the type itself.
@Dandielo
#ICE-207
5acb729 
Changes to engine source code after additioanl refactor of the Array type.
@Dandielo
Finished refactor of the Array type. #ICE-207 State Done
38fb519
@Dandielo
Changes to engine code after finalized Array refactor,
c632710
@Dandielo
[WIP] Partial refactor of the Queue Type.
4ed3854 
#ICE-211
@Dandielo
Update IBT version to 1.12.0-alpha
9322722
@Dandielo
TeamCity - Test commit for license inspections.
26af975
@Dandielo
Finished the refactoring of the ice::Queue type.
2bd9f81 
#ICE-211 Status In Review
No additional features where added.
@Dandielo
Update licenses for changed files compared to branch 'master'
bfb00a8
@Dandielo
Initial work on HashMap refactor.
829c422 
* Introduced new concepts: "AssociativeContainer" and "HashMapContainer"
* Started rebuilding the HashMap type and all associated utilities.
#ICE-213, #ICE-210
@Dandielo
Initial refactor of refactored HashMap API.
3acf0b6 
* Replaced 'empty', 'any' and 'count' with new equivalents.
#ICE-210
@Dandielo
Refactored 'rehash' as 'set_capacity' for the HashMap.
076e1bc 
* Removed some old functions and reintroduced them in the 'HashMap'
* Added additional utility functions to all resizable containers: 'is_full' and 'not_full'
* Added utility for 'has' and 'missing' functions to accept hashable types.
#ICE-213
Remember to put more time into naming the 'has' and 'missing' methods. Something feels not right with them.
#ICE-210
MultiHashMap might be come a real pain in the end.
Dandielo added 15 commits January 18, 2026 15:21
@Dandielo
Updating code after refactoring parts of the HashMap API.
224a30b
@Dandielo
Updating SPDX headers in all new and modified source files.
792d65b
@Dandielo
Finalized the refactor of all existing dyanmic container types.
8ae38d8 
* Introduced new type MultiHashMap that contains an easier to use API compared to the previous one. (This type is still not preety)
(#ICE-207, #ICE-211, #ICE-210) State Done
@Dandielo
Fixes to source code after the API changes.
9cd9576
@Dandielo
Fix missing license headers.
0078af4
@Dandielo
Refactor the 'ShardContainer' type.
bbe30df 
* Instead of a "Array" field it now derived from Array, since it's now just extending/specializing the API interface.
* Additional smaller cleanup in other parts.
@Dandielo
Updating code affected after the refactor.
9fc38d8
@Dandielo
Initial idea to implement paths as using a "mixin" approach on top of…
51c30f7 
… String and HeapString types.

#ICE-214 State In Progress
@Dandielo
Update README.md
7b0990d
@Dandielo
Continued refactor of Path related containers.
dacfaa4
@Dandielo
Finalize the changes to ice::Path and ice::HeapPath types.
2924735 
#ICE-214 State In Review
@Dandielo
Update used FastBuild version to latest released.
ca27968
@Dandielo
Incorporate 'push_format' directly into the "EditableString" mix-in.
ff31d33 
- Moved 'fmt' dependency from 'utils' to 'collections'
#ICE-200, #ICE-214 State Done
@Dandielo
Update license headers.
8760aa4
@Dandielo
Rename and refactor LinkedQueue and LinkedQueueRange types.
a960e5d 
- LinkedQueue(Range) -> AtomicLinkedQueue(Range)
#ICE-215 State Done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Dandielo Dandielo

Labels

enhancement Improvements or additions to code feature Request for a new feature or functionality tech-debt Technical debt that needs to be addressed, but can be tolerated for some time

Projects

IceShard - Overview
Status: Backlog

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Dandielo