Add feature to get deployment hash and deployment result separately#6
Open
nightowl121 wants to merge 4 commits intoicon-project:masterfrom
Open
Add feature to get deployment hash and deployment result separately#6nightowl121 wants to merge 4 commits intoicon-project:masterfrom
nightowl121 wants to merge 4 commits intoicon-project:masterfrom
Conversation
Signed-off-by: Night Owl <nightowl121@protonmail.com>
Signed-off-by: Night Owl <nightowl121@protonmail.com>
…d result for deployment separately Signed-off-by: Night Owl <nightowl121@protonmail.com>
Member
|
DefaultScoreClient does not aim to support asynchronous. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the integration tests, we often require to deploy a large set of contracts. By default, while deploying contracts we need to wait
blockTime * no. of contracts. This creates a synchronous delay in integration test.This PR allows developer to deploy all contracts, get all hashes and then wait for a single block time which helps in asynchronous deployment.