Skip to content

Comments

Add validators for new stable circuits#413

Draft
daveroga wants to merge 39 commits intomasterfrom
PID-3627-add-validators-for-new-circuits
Draft

Add validators for new stable circuits#413
daveroga wants to merge 39 commits intomasterfrom
PID-3627-add-validators-for-new-circuits

Conversation

@daveroga
Copy link
Contributor

  • Add v3 atomic stable validator that supports verification of subversion credentialAtomicQueryV3OnChain / credentialAtomicQueryV3OnChain-16-16-64-16-32 (onchain circuits)
  • Add v3 auth validator that supports authV3 and authV3-8-32 (add them as valid auth methods).
  • Add linkedMultiQuery / linkedMultiQuery3 / linkedMultiQuery5 validators for stable circuits in a single validator.

@daveroga daveroga marked this pull request as draft January 28, 2026 11:07
@coveralls
Copy link

coveralls commented Jan 28, 2026

Pull Request Test Coverage Report for Build 21591393860

Details

  • 891 of 1525 (58.43%) changed or added relevant lines in 26 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-8.3%) to 85.673%

Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/validators/request/CredentialAtomicQueryV3StableValidator.sol 169 171 98.83%
contracts/validators/request/LinkedMultiQueryStableValidator.sol 112 116 96.55%
contracts/validators/auth/AuthV3Validator.sol 57 63 90.48%
contracts/validators/auth/AuthV3_8_32Validator.sol 55 63 87.3%
contracts/lib/groth16-verifiers/Groth16VerifierAuthV3_8_32Wrapper.sol 0 11 0.0%
contracts/lib/groth16-verifiers/Groth16VerifierLinkedMultiQueryWrapper.sol 0 11 0.0%
contracts/lib/groth16-verifiers/Groth16VerifierAuthV3_8_32.sol 0 115 0.0%
contracts/lib/groth16-verifiers/Groth16VerifierLinkedMultiQuery3.sol 0 135 0.0%
contracts/lib/groth16-verifiers/Groth16VerifierLinkedMultiQuery5.sol 0 151 0.0%
contracts/lib/groth16-verifiers/Groth16VerifierLinkedMultiQuery.sol 0 191 0.0%
Totals Coverage Status
Change from base Build 21256008068: -8.3%
Covered Lines: 4771
Relevant Lines: 5569

💛 - Coveralls

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds support for new stable circuit validators for the Polygon ID contracts ecosystem. The changes introduce v3 atomic stable validators, v3 auth validators, and linked multi-query stable validators to support new zero-knowledge proof circuits.

Changes:

  • Added validators for stable circuits: CredentialAtomicQueryV3StableValidator, AuthV3Validator, and LinkedMultiQueryStableValidator
  • Added Groth16 verifier contracts and wrappers for new circuits (v3 stable, authV3, linked multi-query variants)
  • Added comprehensive test files and test data for the new validators
  • Updated deployment scripts and ignition modules to support the new validators
  • Updated @0xpolygonid/js-sdk dependency from 1.38.8 to 1.39.4

Reviewed changes

Copilot reviewed 83 out of 84 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
contracts/validators/request/CredentialAtomicQueryV3StableValidator.sol New validator contract for v3 stable atomic query circuits
contracts/validators/auth/AuthV3Validator.sol New auth validator supporting authV3 and authV3-8-32 circuits
contracts/validators/request/LinkedMultiQueryStableValidator.sol New validator for linked multi-query stable circuits
contracts/lib/groth16-verifiers/*.sol Multiple new verifier contracts and wrappers for stable circuits
ignition/modules/credentialAtomicQueryV3StableValidator.ts Deployment module for v3 stable validator (contains critical bug)
ignition/modules/authV3Validator.ts Deployment module for auth v3 validator
ignition/modules/linkedMultiQueryStable.ts Deployment module for linked multi-query stable validator
test/validators/v3-stable/* Test data files for v3 stable circuits
test/validators/authv3/index.ts Test suite for authV3 validator
test/validators/linked-multi-query/linked-multi-query-stable.test.ts Test suite for linked multi-query stable validator
helpers/constants.ts Added contract info for new validators and verifiers
package.json Updated @0xpolygonid/js-sdk to 1.39.4

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 91 out of 92 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Base automatically changed from PID-3590-migrate-to-hardhat-3 to master February 6, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants