Draft
Conversation
Contributor
daveroga
commented
Jan 28, 2026
- Add v3 atomic stable validator that supports verification of subversion credentialAtomicQueryV3OnChain / credentialAtomicQueryV3OnChain-16-16-64-16-32 (onchain circuits)
- Add v3 auth validator that supports authV3 and authV3-8-32 (add them as valid auth methods).
- Add linkedMultiQuery / linkedMultiQuery3 / linkedMultiQuery5 validators for stable circuits in a single validator.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds support for new stable circuit validators for the Polygon ID contracts ecosystem. The changes introduce v3 atomic stable validators, v3 auth validators, and linked multi-query stable validators to support new zero-knowledge proof circuits.
Changes:
- Added validators for stable circuits: CredentialAtomicQueryV3StableValidator, AuthV3Validator, and LinkedMultiQueryStableValidator
- Added Groth16 verifier contracts and wrappers for new circuits (v3 stable, authV3, linked multi-query variants)
- Added comprehensive test files and test data for the new validators
- Updated deployment scripts and ignition modules to support the new validators
- Updated @0xpolygonid/js-sdk dependency from 1.38.8 to 1.39.4
Reviewed changes
Copilot reviewed 83 out of 84 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| contracts/validators/request/CredentialAtomicQueryV3StableValidator.sol | New validator contract for v3 stable atomic query circuits |
| contracts/validators/auth/AuthV3Validator.sol | New auth validator supporting authV3 and authV3-8-32 circuits |
| contracts/validators/request/LinkedMultiQueryStableValidator.sol | New validator for linked multi-query stable circuits |
| contracts/lib/groth16-verifiers/*.sol | Multiple new verifier contracts and wrappers for stable circuits |
| ignition/modules/credentialAtomicQueryV3StableValidator.ts | Deployment module for v3 stable validator (contains critical bug) |
| ignition/modules/authV3Validator.ts | Deployment module for auth v3 validator |
| ignition/modules/linkedMultiQueryStable.ts | Deployment module for linked multi-query stable validator |
| test/validators/v3-stable/* | Test data files for v3 stable circuits |
| test/validators/authv3/index.ts | Test suite for authV3 validator |
| test/validators/linked-multi-query/linked-multi-query-stable.test.ts | Test suite for linked multi-query stable validator |
| helpers/constants.ts | Added contract info for new validators and verifiers |
| package.json | Updated @0xpolygonid/js-sdk to 1.39.4 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
contracts/lib/groth16-verifiers/Groth16VerifierAuthV3_8_32Wrapper.sol
Outdated
Show resolved
Hide resolved
contracts/lib/groth16-verifiers/Groth16VerifierV3StableWrapper.sol
Outdated
Show resolved
Hide resolved
contracts/lib/groth16-verifiers/Groth16VerifierAuthV3Wrapper.sol
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 91 out of 92 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…dMultiQuery stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.