Open
Conversation
…ый делает запросы на распознавание речи к YandexAPI
…епозитория, где делаются запросы к OpenAI API, а второй уровень сервиса, который настраивается запросы под мою необходимость и уже шлет эти запросы
…часть файлов, добавил возможность работы с бд, а конкретно функции: добавить пользователя, удалить пользователя по id, получить пользователя по id, получить роли пользователя по id, получить всех пользователей, добавить роль для пользователя по id
…исок фильтров. Также сделал регистрацию пользователя
…писал javadoc для всех классов
Cromulent74
reviewed
May 26, 2024
Comment on lines
+20
to
+24
| public YandexClient getYandexRecognition() { | ||
| String apiKey = System.getenv("API_KEY"); | ||
|
|
||
| return new YandexClient(apiKey); | ||
| } |
Collaborator
There was a problem hiding this comment.
Можно отрефакторить с помощью "Inline varriable". И убери квалификатор бина, помести его в название
Cromulent74
reviewed
May 26, 2024
Comment on lines
+15
to
+17
| public AnswerService getAnswerService() { | ||
| return new AnswerService(); | ||
| } |
Cromulent74
reviewed
May 26, 2024
Comment on lines
+3
to
+5
| public class SpeechSynthesis { | ||
|
|
||
| } |
Cromulent74
reviewed
May 26, 2024
Comment on lines
+27
to
+52
| private String getQueryParams() { | ||
| StringBuilder queries = new StringBuilder(); | ||
|
|
||
| if (lang != null) { | ||
| queries.append("lang="); | ||
| queries.append(lang.getLang()); | ||
| } | ||
|
|
||
| if (topic != null) { | ||
| if (!queries.isEmpty()) { | ||
| queries.append("&"); | ||
| } | ||
|
|
||
| queries.append("topic="); | ||
| queries.append(lang.getLang()); | ||
| } | ||
|
|
||
| if (!queries.isEmpty()) { | ||
| queries.append("&"); | ||
| } | ||
|
|
||
| queries.append("profanityFilter="); | ||
| queries.append(profanityFilter); | ||
|
|
||
| if (!queries.isEmpty()) { | ||
| queries.append("&"); |
Collaborator
There was a problem hiding this comment.
Можно применить паттерн "Строитель"
Cromulent74
reviewed
May 26, 2024
Comment on lines
+64
to
+67
| HttpHeaders headers = new HttpHeaders(); | ||
| headers.setContentType(MediaType.APPLICATION_JSON); | ||
| headers.setAccept(Collections.singletonList(MediaType.APPLICATION_JSON)); | ||
| headers.set("Authorization", "Api-Key " + apiKey); |
Collaborator
There was a problem hiding this comment.
Это можно было бы сделать в конструкторе
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.