Update zcuts tests to use z-min-pairs/z-max-pairs#1128
Merged
andreicuceu merged 2 commits intoz-bin-refactoringfrom Mar 23, 2026
Merged
Update zcuts tests to use z-min-pairs/z-max-pairs#1128andreicuceu merged 2 commits intoz-bin-refactoringfrom
andreicuceu merged 2 commits intoz-bin-refactoringfrom
Conversation
…files, remove stale files Co-authored-by: andreicuceu <28951059+andreicuceu@users.noreply.github.com> Agent-Logs-Url: https://github.com/igmhub/picca/sessions/4a972c8d-6f80-4b0e-9e28-447f9190ff96
Copilot
AI
changed the title
[WIP] Update tests in test_3_corr.py for z-bin changes
Update zcuts tests to use z-min-pairs/z-max-pairs
Mar 23, 2026
andreicuceu
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The z-bin refactoring replaced
--z-cut-min/--z-cut-maxwith--z-min-pairs/--z-max-pairs, leaving 7 test functions commented out and their reference files stale. Additionally,picca_export.pywas updated to readZMIN/ZMAXheaders but non-zcuts reference files still hadZCUTMIN/ZCUTMAX, breaking 3 export tests.Test function updates (
test_3_cor.py)--z-cut-min/--z-cut-maxwith--z-min-pairs/--z-max-pairsz_min_pairs/z_max_pairstoreset_cf()andreset_xcf()teardown helpersReference file updates (
test_cor/)cf_zcuts,cf_image_zcuts,dmat_zcuts,cf_cross_zcuts,dmat_cross_zcuts,xcf_zcuts,xdmat_zcutscf_angl_zcuts,metal_dmat_zcuts,fast_metal_dmat_zcuts,wick_zcuts,metal_dmat_cross_zcuts,fast_metal_dmat_cross_zcuts,xcf_angl_zcuts,metal_xdmat_zcuts,xwick_zcuts,cf_zcuts_imagecf.fits.gz,xcf.fits.gz,cf_cross.fits.gzto carryZMIN/ZMAXheaders (instead ofZCUTMIN/ZCUTMAX), fixing the 3 broken export tests🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.