Skip to content

perf: parallelize API calls on project page and topbar #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yoann-apel merged 1 commit into from
Apr 15, 2026
Merged

perf: parallelize API calls on project page and topbar #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions middlewares/topBar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,12 @@ async function getProjectStatusGlobal(req) {
async function getInfo(req, res, next) {
req.topBar = [];

await getJobStatus(req);
await getSessionStatus(req);
await getHostStatus(req);
await getProjectStatusGlobal(req);
await Promise.all([
getJobStatus(req),
getSessionStatus(req),
getHostStatus(req),
getProjectStatusGlobal(req),
]);

next();
}
Expand Down
17 changes: 16 additions & 1 deletion routes/pages/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,22 @@ router.get('/job/:id', topBar.getInfo, jobs.getJob, dependencies.getJobDependenc
});

// project page with id
router.get('/project/:id', topBar.getInfo, projects.getProject, projects.getJobsOfProject, dependencies.getProjectDependencies, (req, res) => {
router.get('/project/:id', async (req, res, next) => {
try {
const wrap = (fn) => new Promise(
(resolve, reject) => fn(req, res, (err) => (err ? reject(err) : resolve())),
);
await Promise.all([
wrap(topBar.getInfo),
wrap(projects.getProject),
wrap(projects.getJobsOfProject),
wrap(dependencies.getProjectDependencies),
]);
next();
} catch (error) {
next(error);
}
}, (req, res) => {
res.render('pages/project', {
topBar: req.topBar,
id: req.params.id,
Expand Down
Loading