Skip to content

fix(release): electron-builder の macOS zip 出力名 -mac.zip に追従 + multi-match ガード#191

Merged
shomatan merged 1 commit into
mainfrom
chore/fix-release-zip-glob
May 13, 2026
Merged

fix(release): electron-builder の macOS zip 出力名 -mac.zip に追従 + multi-match ガード#191
shomatan merged 1 commit into
mainfrom
chore/fix-release-zip-glob

Conversation

@shomatan
Copy link
Copy Markdown
Collaborator

概要

v1.2.0 タグ再走 (run 25776135085) で Compute artifact metadata step が
ls: packages/desktop/release/Ark-*-arm64.zip: No such file or directory で fail。

原因

electron-builder 25 の macOS zip target はデフォルトで
Ark-{version}-arm64-mac.zip (-mac 接尾辞付き) を出力する。
workflow の glob は Ark-*-arm64.zip でこのファイル名にマッチしなかった。

build run の actual output:

• building target=DMG arch=arm64 file=release/Ark-1.2.0-arm64.dmg
• building target=macOS zip arch=arm64 file=release/Ark-1.2.0-arm64-mac.zip

Smoke test (.app bootstrap + bundled SDK claude) は両方 PASS、artifact 名の glob のみ問題。

修正

  1. glob を Ark-*-arm64-mac.zip に変更
  2. codex review の指摘 ([中]) を反映: bash array で取得し 0 件 / 2 件以上を fail、1 件のみ通過させる Assertive Programming に変更

マージ後

main HEAD で v1.2.0 タグを再作成して push → release.yml 再走 → Release 作成。

関連

electron-builder 25 の macOS zip target は `Ark-{version}-arm64-mac.zip`
(`-mac` 接尾辞付き) を出力するが、`Compute artifact metadata` step の
glob は `Ark-*-arm64.zip` で `-mac` を含まなかったため
`ls: No such file or directory` で fail していた。
glob を `Ark-*-arm64-mac.zip` に揃えて修正。

build run: https://github.com/ignission/claude-code-ark/actions/runs/25776135085
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

Warning

Rate limit exceeded

@shomatan has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 34 minutes and 49 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d91abcef-726c-4d4e-9009-18d78cc42239

📥 Commits

Reviewing files that changed from the base of the PR and between 96fb29f and 7b73e48.

📒 Files selected for processing (1)
  • .github/workflows/release.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/fix-release-zip-glob

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@shomatan shomatan merged commit 2bc38bd into main May 13, 2026
2 checks passed
@shomatan shomatan deleted the chore/fix-release-zip-glob branch May 13, 2026 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant