-
-
Notifications
You must be signed in to change notification settings - Fork 0
ci: add tox reusable workflow #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideIntroduces a reusable tox workflow and updates existing CI and publish workflows to call it, simplifying tox job configuration and dependencies while narrowing branch triggers. Flow diagram for updated CI workflow calling reusable tox workflowflowchart TD
A[Push to branch 8.1] --> B[Run ci workflow]
C[Pull request targeting branch 8.1] --> B
subgraph CI_Jobs[ci workflow jobs]
B --> D[Job pre-commit
runs on ubuntu-latest]
C --> E[Job tox
if event is pull_request]
end
subgraph Reusable_Tox[tox reusable workflow]
E --> F[workflow_call with input checkout-ref]
F --> G[tox-package job
uses tox-docker reusable workflow]
F --> H[tox-stubs job
uses tox reusable workflow]
end
Flow diagram for updated publish workflow calling reusable tox workflowflowchart TD
A[Release published event] --> B[Run publish workflow]
subgraph Publish_Jobs[publish workflow jobs]
B --> C[Job tox
uses reusable tox workflow]
C --> D[pypi-upload job
needs tox]
end
subgraph Reusable_Tox[tox reusable workflow]
C --> E[workflow_call with input checkout-ref
set from release tag]
E --> F[tox-package job
uses tox-docker reusable workflow]
E --> G[tox-stubs job
uses tox reusable workflow]
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- The CI workflow no longer runs on the
8.3branch for eitherpushorpull_requestevents; double-check that dropping8.3from CI triggers is intentional and not an accidental regression.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The CI workflow no longer runs on the `8.3` branch for either `push` or `pull_request` events; double-check that dropping `8.3` from CI triggers is intentional and not an accidental regression.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Introduce a reusable tox workflow and update CI and publish workflows to use it for package and stub testing.
Enhancements:
CI: