-
-
Notifications
You must be signed in to change notification settings - Fork 0
ci: add tox reusable workflow #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideIntroduces a reusable tox workflow and updates existing CI and publish workflows to call it, while narrowing CI triggers to the 8.3 branch and simplifying tox-related jobs and dependencies. Flow diagram for publish workflow using reusable tox jobsflowchart TD
A[Release published event] --> B[Trigger publish.yml]
B --> C[tox job]
C --> D[Call reusable tox.yml workflow]
D --> D1[tox-package job using tox-docker.yml]
D --> D2[tox-stubs job using shared tox.yml]
D1 --> E[Tests for package complete]
D2 --> F[Tests for stubs complete]
E --> G[Signal tox job success]
F --> G
G --> H[pypi-upload job]
H --> I[Build distributions]
I --> J[Upload to PyPI]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- In the reusable
.github/workflows/tox.yml, consider exposingpython-versionsandworking-directoryas inputs rather than hardcoding them so the workflow is flexible if you need to run tox for different targets or interpreters in the future. - Now that
tox-packageandtox-stubsare wrapped in thetoxreusable workflow, double-check thatneeds: toxinpublish.ymlaligns with your intended dependency granularity (i.e., you don’t need to wait on only one of the inner jobs specifically).
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the reusable `.github/workflows/tox.yml`, consider exposing `python-versions` and `working-directory` as inputs rather than hardcoding them so the workflow is flexible if you need to run tox for different targets or interpreters in the future.
- Now that `tox-package` and `tox-stubs` are wrapped in the `tox` reusable workflow, double-check that `needs: tox` in `publish.yml` aligns with your intended dependency granularity (i.e., you don’t need to wait on only one of the inner jobs specifically).Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Introduce a reusable tox GitHub Actions workflow and consolidate existing tox jobs to use it.
CI: