Skip to content

Update nextjs.yml (#6) #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dargon789 wants to merge 6 commits into
base: canary
Choose a base branch
from
Open

Update nextjs.yml (#6) #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cc8a3d3
Create SECURITY.md (#1)
Dargon789 Jan 17, 2026
67a5148
Create nextjs.yml
Dargon789 Jan 17, 2026
bc011b2
Update .github/workflows/nextjs.yml
Dargon789 Jan 17, 2026
7ec0207
Dargon789 patch 1 (#5)
Dargon789 Jan 17, 2026
2dcd666
Update nextjs.yml (#6)
Dargon789 Jan 17, 2026
1bf5135
v16.1.1-canary.29 (#7)
Dargon789 Jan 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
282 changes: 282 additions & 0 deletions .config/ast-grep/rule-tests/__snapshots__/no-map-async-cell-snapshot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,282 @@
id: no-map-async-cell
snapshots:
? |
items.into_iter()
.map(async |item| Ok(item.process().await?.cell()))
.try_join()
.await
: labels:
- source: item.process().await?.cell()
style: primary
start: 43
end: 71
- source: |-
items.into_iter()
.map(async |item| Ok(item.process().await?.cell()))
style: secondary
start: 0
end: 73
- source: async |item| Ok(item.process().await?.cell())
style: secondary
start: 27
end: 72
? |
items.into_iter()
.map(async |item| item.process().await.cell())
.try_join()
.await
: labels:
- source: |-
items.into_iter()
.map(async |item| item.process().await.cell())
style: primary
start: 0
end: 68
- source: item.process().await.cell()
style: secondary
start: 40
end: 67
? |
items.into_iter()
.map(async |item| {
Ok(item.process().await?.cell())
})
.try_join()
.await
: labels:
- source: item.process().await?.cell()
style: primary
start: 53
end: 81
- source: |-
items.into_iter()
.map(async |item| {
Ok(item.process().await?.cell())
})
style: secondary
start: 0
end: 89
- source: |-
async |item| {
Ok(item.process().await?.cell())
}
style: secondary
start: 27
end: 88
? |
items.into_iter()
.map(async |item| {
item.process().await.cell()
})
.try_join()
.await
: labels:
- source: |-
items.into_iter()
.map(async |item| {
item.process().await.cell()
})
style: primary
start: 0
end: 84
- source: item.process().await.cell()
style: secondary
start: 50
end: 77
? |
items.into_iter()
.map(|item| async move {
Ok(item.process().await?.cell())
})
.try_join()
.await
: labels:
- source: item.process().await?.cell()
style: primary
start: 58
end: 86
- source: |-
items.into_iter()
.map(|item| async move {
Ok(item.process().await?.cell())
})
style: secondary
start: 0
end: 94
- source: |-
|item| async move {
Ok(item.process().await?.cell())
}
style: secondary
start: 27
end: 93
? |
items.into_iter()
.map(|item| async {
Ok(item.process().await?.cell())
})
.try_join()
.await
: labels:
- source: item.process().await?.cell()
style: primary
start: 53
end: 81
- source: |-
items.into_iter()
.map(|item| async {
Ok(item.process().await?.cell())
})
style: secondary
start: 0
end: 89
- source: |-
|item| async {
Ok(item.process().await?.cell())
}
style: secondary
start: 27
end: 88
? |
map.into_iter()
.map(|(ty, items)| {
(
ty,
ChunkItemBatchGroup {
items,
chunk_groups: this.chunk_groups.clone(),
},
)
})
.map(async |(ty, batch_group)| Ok((ty, batch_group.resolved_cell())))
.try_join()
: labels:
- source: batch_group.resolved_cell()
style: primary
start: 256
end: 283
- source: |-
map.into_iter()
.map(|(ty, items)| {
(
ty,
ChunkItemBatchGroup {
items,
chunk_groups: this.chunk_groups.clone(),
},
)
})
.map(async |(ty, batch_group)| Ok((ty, batch_group.resolved_cell())))
style: secondary
start: 0
end: 286
- source: async |(ty, batch_group)| Ok((ty, batch_group.resolved_cell()))
style: secondary
start: 222
end: 285
? |
modules
.map(async |module| {
let result = module.compute().await?;
result.into_value().cell()
})
: labels:
- source: result.into_value().cell()
style: primary
start: 88
end: 114
- source: |-
modules
.map(async |module| {
let result = module.compute().await?;
result.into_value().cell()
})
style: secondary
start: 0
end: 121
- source: |-
async |module| {
let result = module.compute().await?;
result.into_value().cell()
}
style: secondary
start: 17
end: 120
? |
modules
.map(async |module| {
let result = module.compute().await?;
result.into_value().cell()
})
.try_join()
: labels:
- source: |-
modules
.map(async |module| {
let result = module.compute().await?;
result.into_value().cell()
})
style: primary
start: 0
end: 121
- source: result.into_value().cell()
style: secondary
start: 88
end: 114
? |
paths.map(async |(path, asset)| {
AssetBinding {
name: wasm_edge_var_name(Vc::upcast(*asset)).owned().await?,
}.cell()
})
: labels:
- source: |-
paths.map(async |(path, asset)| {
AssetBinding {
name: wasm_edge_var_name(Vc::upcast(*asset)).owned().await?,
}.cell()
})
style: primary
start: 0
end: 137
- source: |-
AssetBinding {
name: wasm_edge_var_name(Vc::upcast(*asset)).owned().await?,
}.cell()
style: secondary
start: 38
end: 134
? |
paths.map(async |(path, asset)| {
Ok(AssetBinding {
name: wasm_edge_var_name(Vc::upcast(*asset)).owned().await?,
}.cell())
})
.try_join()
.await
: labels:
- source: |-
AssetBinding {
name: wasm_edge_var_name(Vc::upcast(*asset)).owned().await?,
}.cell()
style: primary
start: 41
end: 137
- source: |-
paths.map(async |(path, asset)| {
Ok(AssetBinding {
name: wasm_edge_var_name(Vc::upcast(*asset)).owned().await?,
}.cell())
})
style: secondary
start: 0
end: 141
- source: |-
async |(path, asset)| {
Ok(AssetBinding {
name: wasm_edge_var_name(Vc::upcast(*asset)).owned().await?,
}.cell())
}
style: secondary
start: 10
end: 140
70 changes: 70 additions & 0 deletions .config/ast-grep/rule-tests/no-map-async-cell-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
id: no-map-async-cell
valid:
- |
items.into_iter()
.map(|item| item.process())
.collect()
- |
items.into_iter()
.map(|item| {
SomeStruct { field: item }.cell()
})
.collect()
- |
call_once(|| async {
X{}.cell()
})
invalid:
- |
items.into_iter()
.map(|item| async move {
Ok(item.process().await?.cell())
})
.try_join()
.await
- |
items.into_iter()
.map(|item| async {
Ok(item.process().await?.cell())
})
.try_join()
.await
- |
items.into_iter()
.map(async |item| {
Ok(item.process().await?.cell())
})
.try_join()
.await
- |
items.into_iter()
.map(async |item| Ok(item.process().await?.cell()))
.try_join()
.await
- |
paths.map(async |(path, asset)| {
Ok(AssetBinding {
name: wasm_edge_var_name(Vc::upcast(*asset)).owned().await?,
}.cell())
})
.try_join()
.await
- |
modules
.map(async |module| {
let result = module.compute().await?;
result.into_value().cell()
})
- |
map.into_iter()
.map(|(ty, items)| {
(
ty,
ChunkItemBatchGroup {
items,
chunk_groups: this.chunk_groups.clone(),
},
)
})
.map(async |(ty, batch_group)| Ok((ty, batch_group.resolved_cell())))
.try_join()
26 changes: 26 additions & 0 deletions .config/ast-grep/rules/no-map-async-cell.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# yaml-language-server: $schema=https://raw.githubusercontent.com/ast-grep/ast-grep/main/schemas/rule.json

id: no-map-async-cell
message: Using `.map(async |...| { ...cell() })` causes non-deterministic cell order
note: You probably want to first `try_join()` the async computations before wrapping them in a cell.
severity: error
language: Rust
rule:
all:
- any:
- pattern: $_X.cell()
- pattern: $_X.resolved_cell()
- pattern: ResolvedVc::cell($_X)
- pattern: Vc::cell($_X)
- inside:
stopBy: end
all:
- any:
- pattern: 'async |$$$ARGS| $BODY'
- pattern: 'async move |$$$ARGS| $BODY'
- pattern: '|$$$ARGS| async { $$$BODY }'
- pattern: '|$$$ARGS| async move { $$$BODY }'
- inside:
stopBy: end
field: arguments
pattern: $EXPR.map($$$CLOSURE)
1 change: 1 addition & 0 deletions .github/labeler.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@
{ "type": "user", "pattern": "bgw" },
{ "type": "user", "pattern": "lukesandberg" },
{ "type": "user", "pattern": "mischnic" },
{ "type": "user", "pattern": "mmastrac" },
{ "type": "user", "pattern": "sokra" },
{ "type": "user", "pattern": "timneutkens" },
{ "type": "user", "pattern": "wbinnssmith" }
Expand Down
Loading