Skip to content

Create Visual Studio solution#65

Open
playday3008 wants to merge 2 commits intoikalnytskyi:masterfrom
playday3008:vs
Open

Create Visual Studio solution#65
playday3008 wants to merge 2 commits intoikalnytskyi:masterfrom
playday3008:vs

Conversation

@playday3008
Copy link
Copy Markdown
Contributor

No description provided.

@ikalnytskyi
Copy link
Copy Markdown
Owner

Thanks for the contribution and sorry for not getting to you quicker. One thing I'm missing is reasoning behind this patch, can you help me please to understand it better?

Is this .sln file intended to be consumed by termcolor's contributors, such as you and I, or is it intended to be used as a dependency by other VS projects?

Regardless of the intention, it'd be nice to hook this up with CI if we want to merge this. According to the docs, Windows runners have Visual Studion preinstalled.

https://github.com/actions/virtual-environments/blob/main/images/win/Windows2022-Readme.md#visual-studio-enterprise-2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants