Conversation
Turn on -skiperror. Need to figure out what happened here. Fix libpath for discovery of corelibname.
Remove a number of ifdefs. Add a DiagnosticOptions to allow NoWarn/WarnAsError. These are quite how I want them, but they serve for now. Allow overriding levels using those options. Trap fatal exception.
Fix resolver.
…od. Instead, we now support GetMethod properly on the delegate type itself using _incompleteMethods.
…te causes recursion.
…e emitted as a different underlying type depending on the target. DynamicMethod requires RuntimeTypeHandles, and so cannot accept builders. But, building types on the fly to be used by DynamicMethods is a thing. Think this just worked out on accident previously. But now it's explicit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace all usages of System.Reflection and IKVM.Reflection in the Runtime classes with IKVM.CoreLib.Symbols. This removes nearly all of the #IFDEFs. We should be free to start breaking up the Runtime classes into IKVM.CoreLib.Symbols.