Replace annotations with attributes #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Nice! Care to rebase your branch on Will create a pull request / issue shortly regarding this and will ping you so I can get some feedback. |
uuf6429
force-pushed
the
chore/switch-to-attributes
branch
from
19ad89f to
c051b1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attributes provide better DX (autocompletion, discoverability etc) and since they're parsed natively by php, they're faster and more stable (than phpdoc parsing tools).
Since this package depends on PHP 8.3, might as well make the jump.
I believe this change should not have backward compatibility issues.