-
Notifications
You must be signed in to change notification settings - Fork 2
fix(ai-plugins): make action labels translatable and add German translations #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
maerch
approved these changes
Jan 14, 2026
Removed the "de" sections from all translation JSON files: - plugin-ai-audio-generation-web - plugin-ai-generation-web - plugin-ai-image-generation-web - plugin-ai-sticker-generation-web - plugin-ai-text-generation-web - plugin-ai-video-generation-web
Add setDefaultTranslations() helper that only sets translations for keys that don't already exist. This allows integrators to customize AI plugin labels by calling setTranslations() BEFORE adding plugins, rather than having to override them afterwards. Changes: - Add setDefaultTranslations() to plugin-ai-generation-web - Update all AI plugin entry points to use setDefaultTranslations() - Add ?translations=true query param to demo app for testing - Update i18n.md docs with both pre/post plugin loading approaches - Fix translation key prefixes (@imgly/ vs ly.img.)
Convert all cesdk.i18n.setTranslations() and cesdk.setTranslations() calls to use setDefaultTranslations() helper. This ensures integrators can set custom translations BEFORE plugins load without being overwritten. - Converted 74 files across all AI plugin packages - Added import for setDefaultTranslations from @imgly/plugin-ai-generation-web - Maintains backward compatibility with existing integrations
Remove all hardcoded German translations from AI plugin TypeScript source files. This completes the removal of German translations started in 14cfd6a. Removed German translations from: - plugin-ai-image-generation-web - plugin-ai-video-generation-web - plugin-ai-audio-generation-web - plugin-ai-sticker-generation-web - plugin-ai-generation-web (initializeProviders) - Unit test assertions for German translations
c57017b to
f9be1fc
Compare
- Extract hardcoded translations to translations.json file - Add apps.json symlink for test translations - Now 'AI' panel title gets '&AI' prefix with ?translations=true
Document the new translation pattern that allows integrators to customize translations before plugins load using setDefaultTranslations.
- Translatable action labels with labelKey property - setDefaultTranslations utility for integrator-first translations - External translations.json files for easier customization - Comprehensive i18n documentation in READMEs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
translations.jsonfilestestTranslations.tsto properly use locale-specific translations (was using English for both locales)Fixes https://github.com/imgly/ubq/issues/13630
Test plan
de&for generic,@for provider-specific)🤖 Generated with Claude Code