Triangular distance#50
Open
robertbjornson wants to merge 7 commits into
Open
Conversation
Contributor
|
|
ssnn-airr
reviewed
May 26, 2026
| K.insert(K.end(), Tt.begin(), Tt.end()); | ||
| bump_pairs(Ns, K); | ||
| bump_pairs(K, Ns); | ||
| // bump_pairs(K, Ns); // The bump_pairs(Ns, K) call already handles all N-vs-known-base pairs in both directions because tri_idx normalizes (i,j) and (j,i) to the same lower-triangle position. |
Contributor
There was a problem hiding this comment.
@robertbjornson I made this change (commented out bump_pairs) to your code. Please review.
Contributor
Author
There was a problem hiding this comment.
I"m unclear where this bump_pairs(K, Ns) came from. It wasn't in my checked in code. Seems fine to remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified distance calculation that uses a triangular matrix to save memory.