Skip to content

fix: Memories date#632

Merged
3rob3 merged 1 commit intomainfrom
dev.3rob3.memories
May 8, 2026
Merged

fix: Memories date#632
3rob3 merged 1 commit intomainfrom
dev.3rob3.memories

Conversation

@3rob3
Copy link
Copy Markdown
Collaborator

@3rob3 3rob3 commented Apr 16, 2026

Closes #631

Summary by CodeRabbit

  • Bug Fixes
    • Improved memory search date calculation to properly handle current time and timezone information, replacing the previous UTC-based timestamp approach. This ensures more accurate date-based memory retrieval and anniversary date calculations.

@3rob3 3rob3 added the bug Something isn't working label Apr 16, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 16, 2026

📝 Walkthrough

Walkthrough

Updated MemoryAssetsPool.LoadAssets to compute searchDate using DateTimeOffset.Now instead of constructing a UTC midnight timestamp from DateTime.Today. This modifies the timezone basis and time boundary used for the SearchMemoriesAsync call and affects the yearsAgo calculation.

Changes

Cohort / File(s) Summary
Date Calculation Update
ImmichFrame.Core/Logic/Pool/MemoryAssetsPool.cs
Changed searchDate computation from UTC midnight timestamp to DateTimeOffset.Now, affecting timezone basis and time offset for memories search and year calculation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Possibly related PRs

Suggested labels

fix

Poem

🐰 A moment in time, now captured just right,
From midnight UTC to the present so bright,
DateTimeOffset takes the stage with a bound,
Memories will search where the real time is found!

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title is vague and generic, using non-descriptive terms that don't clearly convey what the date-related fix entails or why it matters. Consider revising to something more specific like 'fix: Use DateTimeOffset.Now for memory search date calculation' to clearly indicate the nature of the fix.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev.3rob3.memories

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@JW-CH JW-CH changed the title Memories fix...yet again fix: Memories date Apr 20, 2026
@3rob3 3rob3 merged commit 8e94c69 into main May 8, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Starting with version 1.0.30, all memories are off by one day

1 participant