You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Improved memory search date calculation to properly handle current time and timezone information, replacing the previous UTC-based timestamp approach. This ensures more accurate date-based memory retrieval and anniversary date calculations.
Updated MemoryAssetsPool.LoadAssets to compute searchDate using DateTimeOffset.Now instead of constructing a UTC midnight timestamp from DateTime.Today. This modifies the timezone basis and time boundary used for the SearchMemoriesAsync call and affects the yearsAgo calculation.
Changes
Cohort / File(s)
Summary
Date Calculation Update ImmichFrame.Core/Logic/Pool/MemoryAssetsPool.cs
Changed searchDate computation from UTC midnight timestamp to DateTimeOffset.Now, affecting timezone basis and time offset for memories search and year calculation.
immichFrame/ImmichFrame#588: Replaces the searchDate source calculation and adjusts year calculations in MemoryAssetsPool.LoadAssets.
Suggested labels
fix
Poem
🐰 A moment in time, now captured just right, From midnight UTC to the present so bright, DateTimeOffset takes the stage with a bound, Memories will search where the real time is found!
🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name
Status
Explanation
Resolution
Docstring Coverage
⚠️ Warning
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.
Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check
❓ Inconclusive
The title is vague and generic, using non-descriptive terms that don't clearly convey what the date-related fix entails or why it matters.
Consider revising to something more specific like 'fix: Use DateTimeOffset.Now for memory search date calculation' to clearly indicate the nature of the fix.
✅ Passed checks (1 passed)
Check name
Status
Explanation
Description Check
✅ Passed
Check skipped - CodeRabbit’s high-level summary is enabled.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches📝 Generate docstrings
Create stacked PR
Commit on current branch
🧪 Generate unit tests (beta)
Create PR with unit tests
Commit unit tests in branch dev.3rob3.memories
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #631
Summary by CodeRabbit