fix(generator/client): append unit to gRPC/HTTP2 transport timeouts#627
Merged
1715173329 merged 1 commit intoJun 9, 2026
Merged
Conversation
`idle_timeout` and `ping_timeout` on the outbound transport were written as bare numbers (e.g. `"15"`), but sing-box parses them as Go durations and requires a unit suffix (`"15s"`). The server-side generator and the URLTest generator already use `strToTime()` for the same fields; align the client outbound to match.
Contributor
Author
Reproduction on a live routerSetting Idle timeout / Ping timeout on a gRPC + Reality VLESS node from the LuCI UI and reloading homeproxy produces this in sing-box refuses to start because CLI workaround until this lands (bypasses the LuCI uci set homeproxy.<node>.http_idle_timeout='10s'
uci set homeproxy.<node>.http_ping_timeout='5s'
uci commit homeproxy
/etc/init.d/homeproxy reloadWith the patch applied, the numeric UI value (e.g. |
Contributor
Author
|
这个东西就是,singbox/xtls要求grpc的idle和ping有时间单位,通常是s 但是因为ui类型检查,又无法保存 所以给你 generate_client.uc 补上了时间单位 |
1715173329
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
idle_timeoutandping_timeouton outbound transport (gRPC / HTTP2+TLS) were emitted as bare numeric strings (e.g."15"), but sing-box parses them as Gotime.Durationand rejects values without a unit suffix.generate_server.uc:175-176) and the URLTest generator (generate_client.uc:819) already wrap the same UCI values instrToTime(); this aligns the client outbound transport to behave the same way.Before:
"idle_timeout": "15"→ sing-box parse error / field dropped.After:
"idle_timeout": "15s"— matches the sing-box v2ray-transport docs.Test plan
/var/run/homeproxy/sing-box-c.jsoncontains"idle_timeout": "<N>s"/"ping_timeout": "<N>s"rather than bare numbers.