scripts: ensure git submodules are initialized#37
Open
maxtheaxe wants to merge 1 commit intoimputnet:mainfrom
Open
scripts: ensure git submodules are initialized#37maxtheaxe wants to merge 1 commit intoimputnet:mainfrom
maxtheaxe wants to merge 1 commit intoimputnet:mainfrom
Conversation
xerrni
suggested changes
Dec 28, 2025
| _image="chromium-builder:trixie-slim" | ||
|
|
||
| # Fail fast: required submodule must be initialized before any Docker work | ||
| if [ ! -f "${_base_dir}/helium-chromium/utils/downloads.py" ] && [ ! -f "${_base_dir}/helium-chromium/utils/clone.py" ]; then |
There was a problem hiding this comment.
this should fail if ANY file is missing not only if both of them.
There was a problem hiding this comment.
additionally do not re write code just define one function in shared.sh verify_submodules and use it here.
| fi | ||
|
|
||
| # One of these utilities must exist if the submodule is initialized | ||
| if [ ! -f "${_main_repo}/utils/downloads.py" ] && [ ! -f "${_main_repo}/utils/clone.py" ]; then |
There was a problem hiding this comment.
this should fail if ANY file is missing not only if both of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error thrown when attempting a build with uninitialized git submodules is not helpful (I ran into it). This PR adds an instruction to initialize them in the README and checks within the build scripts.