Optimize go mod download Docker cache #372
Merged
+28
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakub-id
requested review from
JanisSaldabols and
adamdickmeiss
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Optimizes Docker build caching for Go module downloads by copying module manifests earlier and running go mod download before copying frequently changing sources.
Changes:
- Reordered
COPYsteps sogo.mod/go.sumare copied before module source code to improve layer cache reuse. - Moved
go mod downloadearlier in bothillmockandbrokerDocker builds while retaining BuildKit cache mounts.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| illmock/Dockerfile | Copies illmock/go.mod + go.sum before sources and runs go mod download earlier for better caching. |
| broker/Dockerfile | Copies broker/go.mod + go.sum before broker sources and runs go mod download earlier to avoid invalidating deps cache on source changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.