-
Notifications
You must be signed in to change notification settings - Fork 8
feat: add transplanted 1D quadrature maps, docs, tests #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xywei
wants to merge
11
commits into
inducer:main
Choose a base branch
from
xywei:transplanted-rules
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
9e132f4
feat: add transplanted 1d quadrature
xywei f9884a8
fix: unblock CI
xywei 5f2d7a9
fix: less strict checking for the qbx example script
xywei 3efe064
fix: add typing to transplanted.py
xywei 0b90d2f
fix: add typing to test_quadrature.py
xywei dc4f215
fix: address copilot reviews
xywei 567e9a9
fix: misc fixes in docs and interface
xywei 74b8d51
fix: test regex, simply kte
xywei 7aa08e3
fix: tests
xywei 200d437
fix: remove heavy example
xywei 8988606
fix: test typing
xywei File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel particularly strongly about this, but I haven't heard the term "transplanted" used very often, so it sounds a bit unintuitive to me. Maybe call this
mappedorconformal mapped? Maybe justtransformed? Although we already have aTransformed1DQuadraturethat just does linear transformations.For context, I'm mostly familiar with stuff like this from Kress' Numerical Analysis, e.g. Chapter 9.6 and some of the cited references, so it might just be a different tradition.
(Same for other places where the term is used, depending on what's decided.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks — good point. I kept “transplanted” in this PR to stay consistent with Hale & Trefethen. From what I can tell, its usage mostly appear in complex analysis literature.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fair enough. I'm fine with it if you guys are, just thought of raising the point for those of us less in the weeds of it 😁
One more proposal:
modepy.quadrature.variable_transformationor justmodepy.quadrature.transforms.