Preserve type when applying optimize_mapper#240
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to improve type preservation for the optimize_mapper decorator by using a TypeVar instead of plain type annotations. The decorator applies AST rewriting to mapper classes to optimize their performance, and the change attempts to ensure that type checkers understand that the decorator returns the same class type that was passed in.
Changes:
- Introduced a TypeVar
MapperTto represent mapper classes - Updated the return type of
optimize_mapperfromCallable[[type], type]toCallable[[MapperT], MapperT] - Updated the internal wrapper function and cast operation to use
MapperT
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @majosm