Skip to content

Tzt/feat/worker transaction monitor#499

Open
GabrielTozatti wants to merge 6 commits intostagingfrom
tzt/feat/worker-transaction-monitor
Open

Tzt/feat/worker transaction monitor#499
GabrielTozatti wants to merge 6 commits intostagingfrom
tzt/feat/worker-transaction-monitor

Conversation

@GabrielTozatti
Copy link
Contributor

Description

Add a job to log multisig vault transactions in order to investigate why transactions fail on the final signature. This PR does not fix the issue but enables tracing to identify the root cause.

Summary

  • Implemented a job to log vault multisig transactions using Pino
  • Captures key steps in the signing flow to help identify where the final signature fails
  • Prepares detailed logs for future debugging of multisig transaction issues

Checklist

  • I reviewed my PR code before submitting
  • I ensured that the implementation is working correctly and did not impact other parts of the app
  • I mentioned the PR link in the task

Copy link
Member

@guimroque guimroque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Summary

This PR adds a transaction monitoring cron job to debug multisig vault failures. The implementation includes comprehensive logging, configuration management, and support for both Fuel and EVM signers. While the debugging purpose is clear, there are several critical security and architectural issues that must be addressed.

Strengths

  • Comprehensive logging configuration with LGPD/GDPR compliance redaction patterns in config/logger.ts:22-95
  • Well-structured modular architecture with clear separation of concerns across utils/ folder
  • Proper error handling and transaction state management in queue.ts:53-61
  • Detailed documentation in README.md explaining configuration and usage

Issues

  • 3 critical, 2 important, 2 suggestions

@GabrielTozatti GabrielTozatti requested a review from guimroque March 6, 2026 16:01
Copy link
Member

@guimroque guimroque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

Previous issues have been fixed. Code approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants