FEAT: utxo worker gasless endpoints#509
Open
GabrielTozatti wants to merge 5 commits intotzt/feat/utxo-worker-schema-servicefrom
Open
FEAT: utxo worker gasless endpoints#509GabrielTozatti wants to merge 5 commits intotzt/feat/utxo-worker-schema-servicefrom
GabrielTozatti wants to merge 5 commits intotzt/feat/utxo-worker-schema-servicefrom
Conversation
guimroque
reviewed
Mar 12, 2026
guimroque
reviewed
Mar 12, 2026
guimroque
reviewed
Mar 12, 2026
guimroque
reviewed
Mar 12, 2026
guimroque
reviewed
Mar 12, 2026
guimroque
reviewed
Mar 12, 2026
Member
guimroque
left a comment
There was a problem hiding this comment.
Code Review
Summary
Implements gasless pool endpoints with UTXO reservation and statistics. The implementation follows good patterns with proper error handling and atomic operations, but has several critical issues around input validation and business logic that need to be addressed.
Strengths
- Proper atomic UTXO reservation with MongoDB findOneAndUpdate
- Good error handling structure with custom AppError class
- Clean separation of concerns with controller/routes pattern
- Proper fee-based filtering with 1.5x safety margin
Issues
- 2 critical, 2 important, 1 suggestion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements the gasless pool endpoints on the Worker, covering UTXO reservation with fee-based filtering and pool statistics with total value aggregation.
Summary
POST /worker/gasless/reservewithestimatedMaxFeevalidationamount >= estimatedMaxFee * 1.5ownerfield toGaslessUtxointerfacettlSecondsfromReserveUtxoOptionsGET /worker/gasless/pool/statsreturning counts per status andtotalValuegetStats()aggregation to sumamountacross all UTXOs usingBigInttotalwithtotalValue: stringinGaslessUtxoStatsinterfacestatus()tostats()aligned with new routeChecklist