Open
Conversation
jarauh
approved these changes
Jan 31, 2020
Collaborator
jarauh
left a comment
jarauh
left a comment
There was a problem hiding this comment.
Thanks, looks good! I fixed a few typos.
Let us merge it, and I will move the file to the other repository later.
Collaborator
Author
|
@jarauh should I merge this PR? |
Collaborator
|
Yes, let's merge. Afterwards, we move it to the other repository. If you have the time, you can do it, otherwise I can do it later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've made a tutorial notebook for the code. The notebook reproduces Figure 1.b in Banerjee et al. (2018).
Please let me know if you have any comments or things that you want to improve.