Skip to content

[IMP]google_tag_manager_advanced_tracking, facebook_pixel_tracking#454

Open
fw-bot-adhoc wants to merge 1 commit intoingadhoc:19.0from
adhoc-dev:19.0-18.0-h-111463-jr-5225-fw
Open

[IMP]google_tag_manager_advanced_tracking, facebook_pixel_tracking#454
fw-bot-adhoc wants to merge 1 commit intoingadhoc:19.0from
adhoc-dev:19.0-18.0-h-111463-jr-5225-fw

Conversation

@fw-bot-adhoc
Copy link
Copy Markdown

google_tag_manager_advanced_tracking:

  • Shipping and discount separated from product items in GTM events
  • Reward lines filtered from items, accumulated as discount
  • Replaced legacy Python-dict string parsing with standard JSON.parse

facebook_pixel_tracking:

  • Migrated all events to current Meta Pixel standard (content_ids, contents, currency, value)
  • Fixed critical bug: Purchase event was not being fired (missing event name)
  • Delivery and reward lines excluded from contents

website_sale_advanced_tracking (shared):

  • prepare_purchase_information: delivery/reward lines separated; returns json.dumps()
  • prepare_checkout_information: added is_reward_line flag; item_name uses product name; returns json.dumps()
  • Template: data-product_id on add_to_cart now uses product.id (always present) instead of default_code

Forward-Port-Of: #451

…arated from items / fix facebook pixel tracking #115773

X-original-commit: be6ba09
@roboadhoc
Copy link
Copy Markdown
Contributor

Pull request status dashboard

@fw-bot-adhoc
Copy link
Copy Markdown
Author

@JrAdhoc @cem-adhoc cherrypicking of pull request #451 failed.

stdout:

CONFLICT (modify/delete): facebook_pixel_tracking/static/src/js/website_sale_tracking.js deleted in e9aa8e7dd3e7f495758de7710f7b5500db4fb4ca and modified in e7ed3d553e640efbe0aedd33f438214083ef1525.  Version e7ed3d553e640efbe0aedd33f438214083ef1525 of facebook_pixel_tracking/static/src/js/website_sale_tracking.js left in tree.
Auto-merging google_tag_manager_advanced_tracking/static/src/interactions/website_sale_tracking.js
CONFLICT (content): Merge conflict in google_tag_manager_advanced_tracking/static/src/interactions/website_sale_tracking.js
Auto-merging website_sale_advanced_tracking/views/templates.xml

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

:shipit: you can use git-fw to re-do the forward-port for you locally.

⚠️ after resolving this conflict, you will need to merge it via @roboadhoc.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants