Skip to content

IT-1579: Refactor for use as submodule in IDPS repo#63

Merged
nosheen-adil merged 10 commits into
mainfrom
IT-1579
Jul 7, 2025
Merged

IT-1579: Refactor for use as submodule in IDPS repo#63
nosheen-adil merged 10 commits into
mainfrom
IT-1579

Conversation

@nosheen-adil
Copy link
Copy Markdown
Contributor

@nosheen-adil nosheen-adil commented Jul 1, 2025

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

  • Modify API to support being built as a part of the IDPS app, while still supporting standalone installation via pip
  • Remove use of conda for local development and replace with venv module in python
  • Update docs, removing recommendation for use with anaconda, and provide alternatives for using package on apple silicon
  • Added support for python3.13

Testing Instructions

Unit tests pass on ci/cd across all supported platforms.

For testing locally:

Since we are no longer relying on anaconda for testing virtual envs, an alternative is required for testing x86 binaries on apple silicon. The alternative is to enable rosetta in the terminal:

image

Next install a supported version of python, if not installed already. I used hombrew for this:

brew install python@3.13

Then you should be able to build and test the api locally

make env PYTHON=python3.13
make build THIRD_PARTY_DIR=$(pwd)/../mosaic2/third_party
make test TEST_DATA_DIR=$(pwd)/../mosaic2/test_data

Added/updated tests?

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

@nosheen-adil nosheen-adil requested a review from a team as a code owner July 1, 2025 00:16
@nosheen-adil nosheen-adil requested a review from brunoboivin July 2, 2025 16:11
Copy link
Copy Markdown
Contributor

@brunoboivin brunoboivin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I left a suggestion to help verify the architecture (x86 vs arm) on Mac.
All tests passed.

== 428 passed, 95 skipped, 141 warnings in 58.68s ==

Comment thread README.md
@nosheen-adil nosheen-adil merged commit cb8cf64 into main Jul 7, 2025
5 checks passed
@nosheen-adil nosheen-adil deleted the IT-1579 branch July 7, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants