IT-1579: Refactor for use as submodule in IDPS repo#63
Merged
Conversation
brunoboivin
approved these changes
Jul 3, 2025
Contributor
brunoboivin
left a comment
There was a problem hiding this comment.
Looks good to me. I left a suggestion to help verify the architecture (x86 vs arm) on Mac.
All tests passed.
== 428 passed, 95 skipped, 141 warnings in 58.68s ==
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Testing Instructions
Unit tests pass on ci/cd across all supported platforms.
For testing locally:
Since we are no longer relying on anaconda for testing virtual envs, an alternative is required for testing x86 binaries on apple silicon. The alternative is to enable rosetta in the terminal:
Next install a supported version of python, if not installed already. I used hombrew for this:
Then you should be able to build and test the api locally
Added/updated tests?
have not been included