Skip to content

Control handling of survfit prediction beyond last timepoint#332

Draft
anikoszabo wants to merge 4 commits intoinsightsengineering:mainfrom
anikoszabo:224_noextend
Draft

Control handling of survfit prediction beyond last timepoint#332
anikoszabo wants to merge 4 commits intoinsightsengineering:mainfrom
anikoszabo:224_noextend

Conversation

@anikoszabo
Copy link
Copy Markdown

Add a summary.args = list(extend = TRUE) argument to ard_survival_survfit
When a user passes summary.args = list(extend = FALSE), we return an ARD with the same structure, but the estimates are NA.

Addresses follow-up comment to issue #224


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • If a new ard_*() function was added, it passes the ARD structural checks from cards::check_ard_structure().
  • If a new ard_*() function was added, set_cli_abort_call() has been set.
  • If a new ard_*() function was added and it depends on another package (such as, broom), is_pkg_installed("broom") has been set in the function call and the following added to the roxygen comments: @examplesIf do.call(asNamespace("cardx")$is_pkg_installed, list(pkg = "broom""))
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cardx (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

Add `summary.args = list(extend=TRUE/FALSE)` argument to ard_survival_survfit
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 15, 2026


🎉 Thank you for your contribution! Before this PR can be accepted, we require that you read and agree to our Contributor License Agreement.
You can digitally sign the CLA by posting a comment on this Pull Request in the format shown below. This agreement will apply to this PR as well as all future contributions on this repository.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@anikoszabo
Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA.

@anikoszabo
Copy link
Copy Markdown
Author

recheck

@anikoszabo anikoszabo marked this pull request as draft March 19, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant