Fix attribute when converting factors in ChoicesFilterState#678
Closed
nissinbo wants to merge 1 commit intoinsightsengineering:mainfrom
Closed
Fix attribute when converting factors in ChoicesFilterState#678nissinbo wants to merge 1 commit intoinsightsengineering:mainfrom
nissinbo wants to merge 1 commit intoinsightsengineering:mainfrom
Conversation
Contributor
|
✅ All contributors have signed the CLA |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
|
Hi @nissinbo thanks for your contribution. I was working on this issue and arrived to the same solution that yours. I've also added some unit tests to check this functionality. Therefore we will continue reviewing the other PR, but basically we reached the same fix! |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #611
droplevels()was applied to avoid displaying unused levels in the filter. This dropped the attributes.As a workaround, this PR restores the attributes after applying
droplevels(). Please let me know if you would prefer a different approach.