[currency] fix: Tornado instrumentation to support version 6.5.3
#828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use the documented `HTTPHeaders` interface instead Signed-off-by: Varsha GS <varsha.gs@ibm.com>
- `in` fails while `get()` works—the latter normalizes the input before lookup. Signed-off-by: Varsha GS <varsha.gs@ibm.com>
GSVarsha
added
WIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTPHeaders._dicthas been removed in the latest version:tornado-6.5.3. Using the documented HTTPHeaders interface instead.Tornado normalizes keys to
Http‑Header‑Casefor presentation, e.g.,Content-Type,X-Instana-T. Thus,infails whileget()works because the latter normalizes the input before lookup.Verified the changes on all the supported versions of Tornado :)
Important
Tornado has fixed a couple of
CVEs in this version!