ghci/igvm_attest: handle quote error in notification path#741
Open
haitaohuang wants to merge 1 commit intointel:mainfrom
Open
ghci/igvm_attest: handle quote error in notification path#741haitaohuang wants to merge 1 commit intointel:mainfrom
haitaohuang wants to merge 1 commit intointel:mainfrom
Conversation
haitaohuang
force-pushed
the
error
branch
2 times, most recently
from
3246f78 to
2f9c823
Compare
When MigTD registers for VMM notification of quote completion, ghci returns Ok without checking the status code in the GetQuote buffer. Remove the early return so the status code is checked after the notification is received. Copy shared buffer content to input even for error cases to pass error/status info back to caller. Also log an unexpected errors. Signed-off-by: Haitao Huang <haitaohuang@microsoft.com>
Contributor
Author
|
The CI failure seems timing related |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When MigTD registers for VMM notification of quote completion, ghci returns Ok without checking the status code in the GetQuote buffer. Remove the early return so the status code is checked after the notification is received.
Also log an unexpected error when ghci returns success but quote size is zero.