[SYCL] Split detail builtins implementation into internal headers#21835
Conversation
koparasy
force-pushed
the
compile-time/split-builtins
branch
4 times, most recently
from
b5fe38f to
ead3afc
Compare
koparasy
changed the title
|
@0x12CC This should be the last part on my side. |
koparasy
force-pushed
the
compile-time/split-builtins
branch
from
22a9973 to
656ba9b
Compare
Refactors builtins.hpp into a thin hub plus builtin_helpers.hpp and per-category internal headers. Intended to improve header organization and introduce opportunities for reducing compile-time cost. Introduces KHR inclusion points to the fine grain includes
koparasy
force-pushed
the
compile-time/split-builtins
branch
from
b818b08 to
6ffb7e6
Compare
There was a problem hiding this comment.
I've noticed that KhronosGroup/SYCL-Docs#814 is not merged yet, is it finalized or should we wait for it to be finalized/merged?
There was a problem hiding this comment.
We have a process for this documented here: https://github.com/intel/llvm/blob/sycl/sycl/doc/developer/KHRExtensions.md. I'm not sure if it's applicable to this specific extension since the only way to use it is to include it.
There was a problem hiding this comment.
Ok. At this point and for this KHR I don't believe this is feasible/wise. The KHR is big in the first place (it needs to implement all the new headers) and we already have many headers pushed under that KHR. So I think we should merge this in (once we resolve comments etc.).
The changes under the sycl/detail/ are nice to have regardless of the KHR while splitting builtins into multiple headers under sycl will be beneficial cause it will enable us to internally include less files.
| (void)sycl::half_precision::divide(A, B); | ||
| (void)sycl::half_precision::divide(MA, MB); | ||
| return 0; | ||
| } No newline at end of file |
There was a problem hiding this comment.
Could you please fix EOL issues
There was a problem hiding this comment.
I did, but now code formatter fails on these.
4 participants
Refactors builtins.hpp into a thin hub plus builtin_helpers.hpp and per-category internal headers.
Intended to improve header organization and introduce opportunities for reducing compile-time cost.
Implements the
builtin_*.hppfiles listed in KhronosGroup/SYCL-Docs#814