-
Notifications
You must be signed in to change notification settings - Fork 56
CVS-176786: Draft for Documentation update and deprecation notices #905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh-pages
Are you sure you want to change the base?
Conversation
…nfig parsing value error in documentation examples
jatinwadhwa921
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls make the changes accordingly
MayureshV1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also change line#90 and mention
The following provider options are deprecated since ORT 1.23 and should be migrated to load_config for better compatibility with future releases
| "DEVICE_PROPERTIES": { | ||
| "CPU": { | ||
| "INFERENCE_PRECISION_HINT": "f32", | ||
| "NUM_STREAMS": "3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the INFERENCE_NUM_THREADS reference since it is a low level setting that is better ignored by app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, removed INFERENCE_NUM_THREADS from the example as it's a low-level setting.
Added versions deprecation notices and updated documentation
https://jira.devtools.intel.com/browse/CVS-176786