[OV EP] Followup: External initializers in memory - remove the 32MB threshold #919
+130
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR removes the artificial 32MB threshold for external initializers in the OpenVINO execution provider, allowing the feature to be used more broadly without size limitations.
Changes:
- Removed the 32MB size threshold check in backend_manager.cc
- Refactored the test code to use static test suite setup/teardown for better resource management
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| onnxruntime/core/providers/openvino/backend_manager.cc | Removed the MAX_EMBEDDED_INITIALIZER_SIZE constant and simplified the condition for using external initializers |
| onnxruntime/test/providers/openvino/openvino_ep_ext_init.cc | Refactored test to use static class members and suite-level setup/teardown, eliminating per-test file operations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MayureshV1
requested review from
Copilot and
ericcraw
and removed request for
ericcraw
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ericcraw
approved these changes
Feb 6, 2026
Remove the 32MB threshold for embedding external initializers in the ONNX model proto. Now, if external weights are present and there is more than one external initializer, data will not be embedded regardless of size. CVS-174613
Refactored the OVEP_ExtInit_Tests to generate and load the ONNX model and large external initializer data only once per test suite, rather than per test case. Model and weights are now stored as static members and cleaned up after all tests. This reduces redundant file I/O and memory usage. Test logic and device probing remain unchanged.
Replaced manual error handling (throwing std::runtime_error) with Google Test ASSERT_TRUE assertions for model serialization, file opening, and memory loading. Also remove explicit calls to .close() of file streams, since they are in separate scopes.
intbf
force-pushed
the
ext_init_remove_threshold
branch
from
e81f35d to
c78fe8a
Compare
javier-intel
approved these changes
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To stay on the safer side, the ext initializer feature was limited with a 32MB threshold for all ext initializers. We can now remove the artificial condition.
Related to CVS-174613