add py.typed marker for Python client v3.0.2#202
Merged
mcharytoniuk merged 1 commit intomainfrom Mar 28, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds PEP 561 typing support for the paddler-client Python package so downstream type checkers treat it as a typed distribution, while also cleaning up strict-typing issues in tests and applying consistent Ruff formatting.
Changes:
- Add
paddler_client/py.typedmarker file for PEP 561 compliance. - Bump package version from
3.0.1to3.0.2. - Fix mypy
--strictissues and apply Ruff formatting updates across tests and client modules.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| paddler_client_python/pyproject.toml | Bumps package version to 3.0.2 (and already advertises typed status via classifier). |
| paddler_client_python/paddler_client/py.typed | Adds PEP 561 marker to make the published package recognized as typed. |
| paddler_client_python/tests/test_types.py | Adjusts assertions (e.g., .value, isinstance) to satisfy mypy strict typing; minor formatting cleanups. |
| paddler_client_python/tests/test_stream_ndjson.py | Ruff-formatting of JSON construction and string concatenation in NDJSON stream tests. |
| paddler_client_python/tests/test_inference_message.py | Ruff-formatting of nested dict literals and JSON string assembly in inference message parsing tests. |
| paddler_client_python/tests/test_client_inference.py | Ruff-formatting of JSON response fixtures and assertion formatting in client inference tests. |
| paddler_client_python/tests/conftest.py | Ruff-formatting of comprehensions and exception raising in async test helpers. |
| paddler_client_python/paddler_client/inference_socket_url.py | Ruff-formatting of urlunparse call layout. |
| paddler_client_python/paddler_client/inference_socket_pool.py | Ruff-formatting of connection list initialization. |
| paddler_client_python/paddler_client/inference_socket_connection.py | Ruff-formatting of type annotations and logging call formatting. |
| paddler_client_python/paddler_client/error.py | Ruff-formatting of error constructors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
py.typedmarker file so downstream type checkers recognize the package as typed.valuecomparisons,isinstancechecks for custom serializer outputs)Test plan
mypy --strictpasses (50 files, 0 errors)ruff checkandruff format --checkpasspytestpasses (99 passed, 11 skipped integration tests)py.typedconfirmed present in built wheel