Add Downward API volume fieldRef support for pod metadata files by Copilot · Pull Request #530 · interlink-hq/interLink

Copilot · 2026-05-09T09:51:50Z

InterLink already resolved Downward API fieldRef for env vars, but volume-based Downward API metadata files were incomplete. This PR extends volume handling so pods can mount metadata files from both projected and direct downwardAPI volumes with Kubernetes-standard field paths.

Downward API field path coverage
- Added field resolution for volume items:
  - metadata.name, metadata.namespace, metadata.uid
  - metadata.labels, metadata.annotations
  - spec.nodeName, spec.serviceAccountName
  - status.podIP, status.hostIP
- Kept unsupported selectors as non-fatal (logged and skipped), matching existing behavior.
Direct downwardAPI volume support
- Added handling for volumes[].downwardAPI in remoteExecutionHandleVolumes (previously only projected sources were handled for this path).
- Populates ProjectedVolumeMaps for downstream execution in the same way as other projected sources.
Deterministic metadata file rendering
- Implemented stable serialization for metadata.labels / metadata.annotations as newline-delimited key="value" entries with sorted keys for deterministic output.
Targeted unit coverage
- Added tests validating:
  - all newly supported fieldRef mappings for projected Downward API sources
  - end-to-end handling of direct downwardAPI volumes

volumes:
  - name: podinfo
    downwardAPI:
      items:
        - path: pod-name
          fieldRef: { fieldPath: metadata.name }
        - path: labels
          fieldRef: { fieldPath: metadata.labels }
        - path: annotations
          fieldRef: { fieldPath: metadata.annotations }

netlify · 2026-05-09T09:51:54Z

✅ Deploy Preview for interlink-dev canceled.

Name	Link
🔨 Latest commit	`4457bcc`
🔍 Latest deploy log	https://app.netlify.com/projects/interlink-dev/deploys/6a2005f928cc4c0008db5a7a

Agent-Logs-Url: https://github.com/interlink-hq/interLink/sessions/966b79b9-f6b2-4041-8aba-bfb574abeab5 Co-authored-by: dciangot <4144326+dciangot@users.noreply.github.com>

dciangot · 2026-05-09T11:32:04Z

@copilot lint action is failing

Agent-Logs-Url: https://github.com/interlink-hq/interLink/sessions/f88fe7ab-00db-421c-93d7-5a24efd018c8 Co-authored-by: dciangot <4144326+dciangot@users.noreply.github.com>

Copilot · 2026-05-09T11:35:41Z

@copilot lint action is failing

Fixed. The lint failure was due to staticcheck QF1012 in formatDownwardAPIMetadataMap; I updated the string building to satisfy lint without changing behavior. Addressed in commit d379093.

Copilot

Pull request overview

This PR extends InterLink’s Downward API handling for volume-mounted metadata files by resolving additional fieldRef paths and adding support for direct volumes[].downwardAPI (not only projected sources). It also makes label/annotation rendering deterministic to avoid non-reproducible output from map iteration.

Changes:

Refactors Downward API volume item processing into shared helpers and adds support for more fieldRef paths (incl. labels/annotations, node/service account, pod/host IPs).
Adds handling for direct DownwardAPI volumes in remoteExecutionHandleVolumes by populating ProjectedVolumeMaps.
Adds unit tests covering the new field paths and the direct downwardAPI volume path.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
`pkg/virtualkubelet/execute.go`	Adds shared Downward API resolution helpers and new handling for direct `DownwardAPI` volumes.
`pkg/virtualkubelet/execute_test.go`	Adds tests for the expanded fieldRef mapping and direct `downwardAPI` volumes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Diego Ciangottini <diego.ciangottini@gmail.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

+				case volume.DownwardAPI != nil:
+					projectedVolume := v1.ConfigMap{
+						ObjectMeta: metav1.ObjectMeta{Name: volume.Name},
+						Data:       make(map[string]string),
+					}
+					log.G(ctx).Debug("Adding to PodCreateRequests the downwardAPI volume ", volume.Name)
+


+	require.Len(t, req.ProjectedVolumeMaps, 1)
+	assert.Equal(t, "podinfo", req.ProjectedVolumeMaps[0].Name)
+	assert.Equal(t, "test-pod", req.ProjectedVolumeMaps[0].Data["pod-name"])
+	assert.Equal(t, "app=\"demo\"\n", req.ProjectedVolumeMaps[0].Data["labels"])
+	assert.Equal(t, "a=\"b\"\n", req.ProjectedVolumeMaps[0].Data["annotations"])


Initial plan

5876863

Copilot AI assigned Copilot and dciangot May 9, 2026

Copilot started work on behalf of dciangot May 9, 2026 09:51 View session

Copilot AI linked an issue May 9, 2026 that may be closed by this pull request

Add support for Downward API volumes (fieldRef in volume mounts) #443

Closed

Copilot AI and others added 2 commits May 9, 2026 09:55

feat: support downwardAPI fieldRef volume mappings

0a48e7b

Agent-Logs-Url: https://github.com/interlink-hq/interLink/sessions/966b79b9-f6b2-4041-8aba-bfb574abeab5 Co-authored-by: dciangot <4144326+dciangot@users.noreply.github.com>

chore: address review feedback on downwardAPI implementation

982cc84

Agent-Logs-Url: https://github.com/interlink-hq/interLink/sessions/966b79b9-f6b2-4041-8aba-bfb574abeab5 Co-authored-by: dciangot <4144326+dciangot@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add support for Downward API volumes~~ Add Downward API volume fieldRef support for pod metadata files May 9, 2026

Copilot finished work on behalf of dciangot May 9, 2026 10:00

Copilot AI requested a review from dciangot May 9, 2026 10:00

Copilot started work on behalf of dciangot May 9, 2026 11:32 View session

Copilot AI and others added 2 commits May 9, 2026 11:34

fix: satisfy lint staticcheck in downward API formatter

4e728a6

Agent-Logs-Url: https://github.com/interlink-hq/interLink/sessions/f88fe7ab-00db-421c-93d7-5a24efd018c8 Co-authored-by: dciangot <4144326+dciangot@users.noreply.github.com>

chore: refine lint fix to avoid ignored fmt errors

d379093

Agent-Logs-Url: https://github.com/interlink-hq/interLink/sessions/f88fe7ab-00db-421c-93d7-5a24efd018c8 Co-authored-by: dciangot <4144326+dciangot@users.noreply.github.com>

Copilot finished work on behalf of dciangot May 9, 2026 11:36

dciangot marked this pull request as ready for review May 9, 2026 17:05

Copilot AI review requested due to automatic review settings May 9, 2026 17:05

Copilot started reviewing on behalf of dciangot May 9, 2026 17:06 View session

Copilot AI reviewed May 9, 2026

View reviewed changes

Comment thread pkg/virtualkubelet/execute.go

Potential fix for pull request finding

17ef1f1

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Diego Ciangottini <diego.ciangottini@gmail.com>

Copilot started work on behalf of dciangot May 9, 2026 17:13 View session

Copilot finished work on behalf of dciangot May 9, 2026 17:14

dciangot requested a review from Copilot June 3, 2026 07:59

Copilot started reviewing on behalf of dciangot June 3, 2026 07:59 View session

Copilot AI reviewed Jun 3, 2026

View reviewed changes

Copilot started work on behalf of dciangot June 3, 2026 08:08 View session

Copilot AI added 2 commits June 3, 2026 08:13

fix: respect projected volume flag for downward API

738f15e

chore: polish downward API warning log

4a64632

Copilot finished work on behalf of dciangot June 3, 2026 08:17

Copilot started work on behalf of dciangot June 3, 2026 08:49 View session

fix e2e envFrom secret resolution

8a609d3

Copilot finished work on behalf of dciangot June 3, 2026 09:03

Copilot started work on behalf of dciangot June 3, 2026 09:05 View session

Fix lint goconst warning in execute tests

6af8790

Copilot finished work on behalf of dciangot June 3, 2026 09:12

Copilot started work on behalf of dciangot June 3, 2026 09:54 View session

Add e2e override mechanism and template overrides to fix flaky 095 test

4457bcc

Copilot finished work on behalf of dciangot June 3, 2026 10:46

dciangot merged commit 6fb734f into main Jun 3, 2026
19 of 20 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Downward API volume fieldRef support for pod metadata files#530

Add Downward API volume fieldRef support for pod metadata files#530
dciangot merged 11 commits into
mainfrom
copilot/add-downward-api-volume-support

Copilot AI commented May 9, 2026 •

edited

Loading

Uh oh!

netlify Bot commented May 9, 2026 •

edited

Loading

Uh oh!

dciangot commented May 9, 2026

Uh oh!

Copilot AI commented May 9, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented May 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented May 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for interlink-dev canceled.

Uh oh!

dciangot commented May 9, 2026

Uh oh!

Copilot AI commented May 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented May 9, 2026 •

edited

Loading

netlify Bot commented May 9, 2026 •

edited

Loading