Skip to content

Fix issue15 private registry support#16

Open
antoinetran wants to merge 6 commits into
interlink-hq:mainfrom
antoinetran:fix_issue15_private_registry_support
Open

Fix issue15 private registry support#16
antoinetran wants to merge 6 commits into
interlink-hq:mainfrom
antoinetran:fix_issue15_private_registry_support

Conversation

@antoinetran

Copy link
Copy Markdown
Contributor

Summary

All described in the related issue description.
Tested working in HPC where private registry is mandatory, and direct docker pull is not possible.

Related issue :
#15

@antoinetran antoinetran force-pushed the fix_issue15_private_registry_support branch from 9b12542 to 4a226d9 Compare July 24, 2025 15:24
…fields + added

pullSecrets and pullPolicy => break image override compatibility
test-connection with namespace

Signed-off-by: antoinetran <antoinetran@users.noreply.github.com>
@antoinetran antoinetran force-pushed the fix_issue15_private_registry_support branch from 4a226d9 to b28ebc9 Compare July 24, 2025 15:50

@dciangot dciangot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antoinetran LGTM. I need to check where the impact is in the documentation and installer script. I cannot release it without having the changes ready also there.

…age + improv

template

Signed-off-by: antoinetran <antoinetran@users.noreply.github.com>
…Policy

Signed-off-by: antoinetran <antoinetran@users.noreply.github.com>
Signed-off-by: antoinetran <antoinetran@users.noreply.github.com>
Signed-off-by: antoinetran <antoinetran@users.noreply.github.com>
@antoinetran

antoinetran commented Jul 29, 2025

Copy link
Copy Markdown
Contributor Author

Also includes a fix in values.yaml and regression fix of kubernetesApiCaCrt indent

Signed-off-by: antoinetran <antoinetran@users.noreply.github.com>
@antoinetran

Copy link
Copy Markdown
Contributor Author

Includes an improvement over the slurm config yaml in the values.yaml: it can either be a string (as before to not break compatibility), but also a dict. The purpose is to be able to override this config particular values.yaml with others. Without this, there would be duplication of the whole slurm config yaml. Example with the improvement:
values.yaml

plugin:
  config: # <- not a string anymore
    SingularityPath: "singularity"
    ExportPodData: true
    DataRootFolder: ".local/interlink/jobs/"
...

values-somehpc1.yaml

plugin:
  config: # <- not a string anymore
    # Any comment
    DataRootFolder: "/new/path/specific/to/hpc1"

would result in a merge of both plugin config. The drawback is that the comments or ordering are lost in the rendered file but this is not really important usually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants