[PB-5819]: feature/add original location column for trash#1951
Merged
Conversation
Deploying drive-web with
|
| Latest commit: |
2807ca3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://10db1584.drive-web.pages.dev |
| Branch Preview URL: | https://feature-trash-redesign.drive-web.pages.dev |
CandelR
reviewed
May 8, 2026
Comment on lines
+97
to
+100
| parent?: { | ||
| plainName: string; | ||
| status: FileStatus; | ||
| }; |
Collaborator
There was a problem hiding this comment.
we should add the field to the sdk types also?
Contributor
Author
There was a problem hiding this comment.
Not needed as this type is only for trashed items (an EP only used for web - GET /trash/paginated).
|
|
||
| {isTrash && ( | ||
| <div className="block shrink-0 w-date items-center whitespace-nowrap"> | ||
| <p>{parentFolderName}</p> |
Collaborator
There was a problem hiding this comment.
I've tested it and I can only see the “parent” field as null in the folders, it doesn't appear in the files, and it always comes back as null.
Is the backend ready yet?
Contributor
Author
There was a problem hiding this comment.
The backend is not merged yet.
Contributor
Author
There was a problem hiding this comment.
The backend has been merged (it will be deployed in ~5 min)
larryrider
previously approved these changes
May 11, 2026
CandelR
previously approved these changes
May 11, 2026
|
CandelR
approved these changes
May 11, 2026
larryrider
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding a column for trash view called "Original location" where we display the parent folder name to give the user more context.
Related Issues
Related Pull Requests
Checklist
Testing Process
Additional Notes