Skip to content

fix: adopt firebase-android-sdk 34.13.0#9021

Merged
mikehardy merged 1 commit into
mainfrom
android-sdk-latest
May 15, 2026
Merged

fix: adopt firebase-android-sdk 34.13.0#9021
mikehardy merged 1 commit into
mainfrom
android-sdk-latest

Conversation

@russellwheatley
Copy link
Copy Markdown
Member

Description

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Firebase SDK version to 34.13.0 to ensure the project remains current with the latest Firebase releases and improvements.

Highlights

  • Dependency Update: Updated the Firebase BOM version from 34.12.0 to 34.13.0 across documentation and package configuration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Firebase Android BoM version from 34.12.0 to 34.13.0 in both the documentation and the app's package configuration. The reviewer noted that this dependency update increases regression risk and requested that a test plan be added to the pull request description, citing the repository's testing guidelines.

Comment thread packages/app/package.json
@russellwheatley russellwheatley changed the title fix: adopt firebase-js-sdk 34.13.0 fix: adopt firebase-android-sdk 34.13.0 May 13, 2026
@mikehardy mikehardy force-pushed the android-sdk-latest branch from eeef458 to d061eb3 Compare May 15, 2026 03:26
@mikehardy mikehardy marked this pull request as ready for review May 15, 2026 03:26
Copy link
Copy Markdown
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - fixed the commit (title was re firebase-js-sdk but this is the android bump) and re-pushed - already passed android CI

@mikehardy mikehardy merged commit 5fcaff1 into main May 15, 2026
17 of 18 checks passed
@mikehardy mikehardy deleted the android-sdk-latest branch May 15, 2026 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants