fix: adopt firebase-android-sdk 34.13.0#9021
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Firebase SDK version to 34.13.0 to ensure the project remains current with the latest Firebase releases and improvements. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the Firebase Android BoM version from 34.12.0 to 34.13.0 in both the documentation and the app's package configuration. The reviewer noted that this dependency update increases regression risk and requested that a test plan be added to the pull request description, citing the repository's testing guidelines.
eeef458 to
d061eb3
Compare
mikehardy
left a comment
There was a problem hiding this comment.
LGTM - fixed the commit (title was re firebase-js-sdk but this is the android bump) and re-pushed - already passed android CI
Description
Related issues
Release Summary
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter