Skip to content

fix(ios): import RCTBridgeModule.h directly in .m files using RCT_EXPORT_* macros #9026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wneel wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(ios): import RCTBridgeModule.h directly in .m files using RCT_EXPORT_* macros #9026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/analytics/ios/RNFBAnalytics/RNFBAnalyticsModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*
*/

#import <React/RCTBridgeModule.h>
#import <Firebase/Firebase.h>
#import <React/RCTUtils.h>
Comment on lines +18 to 20
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Grouping React framework imports together improves code readability and follows common Objective-C conventions for organizing dependencies.

#import <Firebase/Firebase.h>
#import <React/RCTBridgeModule.h>
#import <React/RCTUtils.h>


Expand Down
1 change: 1 addition & 0 deletions packages/app-check/ios/RNFBAppCheck/RNFBAppCheckModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*
*/

#import <React/RCTBridgeModule.h>
#import <Firebase/Firebase.h>
#import <FirebaseAppCheck/FIRAppCheck.h>

Expand Down
1 change: 1 addition & 0 deletions packages/app-distribution/ios/RNFBAppDistribution/RNFBAppDistributionModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*
*/

#import <React/RCTBridgeModule.h>
#import <Firebase/Firebase.h>
#import <React/RCTUtils.h>

Expand Down
1 change: 1 addition & 0 deletions packages/app/ios/RNFBApp/RNFBAppModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*
*/

#import <React/RCTBridgeModule.h>
#import <Firebase/Firebase.h>
#import <React/RCTUtils.h>

Expand Down
1 change: 1 addition & 0 deletions packages/app/ios/RNFBApp/RNFBUtilsModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*
*/

#import <React/RCTBridgeModule.h>
#import <React/RCTUtils.h>

#import "RNFBApp/RNFBSharedUtils.h"
Expand Down
1 change: 1 addition & 0 deletions packages/auth/ios/RNFBAuth/RNFBAuthModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*
*/

#import <React/RCTBridgeModule.h>
#import <Firebase/Firebase.h>
#import <React/RCTUtils.h>

Expand Down
1 change: 1 addition & 0 deletions packages/crashlytics/ios/RNFBCrashlytics/RNFBCrashlyticsModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
#include <Foundation/Foundation.h>
#include <sys/sysctl.h>

#import <React/RCTBridgeModule.h>
#import <React/RCTConvert.h>
#import <React/RCTLog.h>
#import <React/RCTUtils.h>
Expand Down
1 change: 1 addition & 0 deletions packages/database/ios/RNFBDatabase/RNFBDatabaseModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*
*/

#import <React/RCTBridgeModule.h>
#import <Firebase/Firebase.h>
#import <React/RCTUtils.h>

Expand Down
1 change: 1 addition & 0 deletions packages/database/ios/RNFBDatabase/RNFBDatabaseOnDisconnectModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*
*/

#import <React/RCTBridgeModule.h>
#import <Firebase/Firebase.h>
#import <React/RCTUtils.h>

Expand Down
1 change: 1 addition & 0 deletions packages/database/ios/RNFBDatabase/RNFBDatabaseQueryModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*
*/

#import <React/RCTBridgeModule.h>
#import <React/RCTUtils.h>

#import "RNFBDatabaseCommon.h"
Expand Down
1 change: 1 addition & 0 deletions packages/database/ios/RNFBDatabase/RNFBDatabaseReferenceModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*
*/

#import <React/RCTBridgeModule.h>
#import <Firebase/Firebase.h>
#import <React/RCTUtils.h>

Expand Down
1 change: 1 addition & 0 deletions packages/database/ios/RNFBDatabase/RNFBDatabaseTransactionModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*
*/

#import <React/RCTBridgeModule.h>
#import <Firebase/Firebase.h>
#import <React/RCTUtils.h>

Expand Down
1 change: 1 addition & 0 deletions packages/firestore/ios/RNFBFirestore/RNFBFirestoreCollectionModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*
*/

#import <React/RCTBridgeModule.h>
#import <RNFBApp/RNFBRCTEventEmitter.h>
#if __has_include(<RNFBFirestore/RNFBFirestore-Swift.h>)
// This import will work in situations where `use_frameworks!` is in use
Expand Down
1 change: 1 addition & 0 deletions packages/firestore/ios/RNFBFirestore/RNFBFirestoreDocumentModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*
*/

#import <React/RCTBridgeModule.h>
#import <RNFBApp/RNFBRCTEventEmitter.h>
#import <React/RCTUtils.h>

Expand Down
1 change: 1 addition & 0 deletions packages/firestore/ios/RNFBFirestore/RNFBFirestoreModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*
*/

#import <React/RCTBridgeModule.h>
#import "RNFBFirestoreModule.h"
#import <RNFBApp/RNFBRCTEventEmitter.h>
#import <React/RCTUtils.h>
Comment on lines +18 to 21
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

It is a standard convention in Objective-C to place the primary header of the module at the top of the imports. Additionally, grouping framework imports (like React) together enhances maintainability.

#import "RNFBFirestoreModule.h"
#import <React/RCTBridgeModule.h>
#import <React/RCTUtils.h>
#import <RNFBApp/RNFBRCTEventEmitter.h>

Expand Down
1 change: 1 addition & 0 deletions packages/firestore/ios/RNFBFirestore/RNFBFirestoreTransactionModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*
*/

#import <React/RCTBridgeModule.h>
#import <RNFBApp/RNFBRCTEventEmitter.h>
#import <React/RCTUtils.h>

Expand Down
1 change: 1 addition & 0 deletions packages/in-app-messaging/ios/RNFBFiam/RNFBFiamModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*
*/

#import <React/RCTBridgeModule.h>
#import <Firebase/Firebase.h>
#import <React/RCTConvert.h>
#import <React/RCTUtils.h>
Expand Down
1 change: 1 addition & 0 deletions packages/installations/ios/RNFBInstallations/RNFBInstallationsModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*
*/

#import <React/RCTBridgeModule.h>
#import <Firebase/Firebase.h>
#import <React/RCTUtils.h>

Expand Down
1 change: 1 addition & 0 deletions packages/messaging/ios/RNFBMessaging/RNFBMessagingModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*
*/

#import <React/RCTBridgeModule.h>
#import <Firebase/Firebase.h>
#import <RNFBApp/RNFBSharedUtils.h>
#import <React/RCTConvert.h>
Expand Down
1 change: 1 addition & 0 deletions packages/perf/ios/RNFBPerf/RNFBPerfModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*
*/

#import <React/RCTBridgeModule.h>
#import <React/RCTConvert.h>
#import <React/RCTUtils.h>

Expand Down
1 change: 1 addition & 0 deletions packages/remote-config/ios/RNFBConfig/RNFBConfigModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*
*/

#import <React/RCTBridgeModule.h>
#import <Firebase/Firebase.h>
#import <React/RCTConvert.h>
#import <React/RCTUtils.h>
Expand Down
1 change: 1 addition & 0 deletions packages/storage/ios/RNFBStorage/RNFBStorageModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*
*/

#import <React/RCTBridgeModule.h>
#import <Firebase/Firebase.h>
#import <React/RCTUtils.h>

Expand Down
Loading