Refactor to_text() to return string instead of bytes#493
Merged
rmilecki merged 1 commit intoinvoice-x:masterfrom Mar 12, 2023
Merged
Refactor to_text() to return string instead of bytes#493rmilecki merged 1 commit intoinvoice-x:masterfrom
rmilecki merged 1 commit intoinvoice-x:masterfrom
Conversation
Collaborator
rmilecki
commented
Mar 12, 2023
Function name "to_text" suggests it should return a text. Python uses str type for storing texts. Having that function return bytes was counter-intuitive. This also simplifies code as most input methods deal with str type. With this change there is no need to encode str into bytes and decode it back. There are actually only 2 input methods dealing with bytes: "pdftotext" and "tesseract". Make them decode bytes into str before returning from to_text().
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.