Skip to content
This repository was archived by the owner on May 4, 2022. It is now read-only.

Comments

aggregated image to bottom action-sheet#1027

Open
Leo1305Pineda wants to merge 1 commit intoionic-team:masterfrom
Leo1305Pineda:master
Open

aggregated image to bottom action-sheet#1027
Leo1305Pineda wants to merge 1 commit intoionic-team:masterfrom
Leo1305Pineda:master

Conversation

@Leo1305Pineda
Copy link

Add the img tag on the button for custom image use

<img [src]="b.img" *ngIf="b.img" class="action-sheet-img">
origin issues
edited issues

Changes

  • action-sheet.wp.scss and action-sheet.md.scss
    `.action-sheet-md .action-sheet-icon {
    @include padding(0);
    @include text-align($action-sheet-md-icon-text-align);

    width: $action-sheet-md-icon-width;

    font-size: $action-sheet-md-icon-font-size;
    vertical-align: $action-sheet-md-icon-vertical-align;

    @include deprecated-variable(margin, $action-sheet-md-icon-margin) {
    @include margin($action-sheet-md-icon-margin-top, $action-sheet-md-icon-margin-end, $action-sheet-md-icon-margin-bottom, $action-sheet-md-icon-margin-start);
    }
    }`

  • action-sheet-options.ts
    export interface ActionSheetButton { text?: string; role?: string; icon?: string; cssClass?: string; handler?: () => boolean|void; }

  • action-sheet-controller.ts and action-sheet-component.ts
    <ion-icon [name]="b.icon" *ngIf="b.icon" class="action-sheet-icon"></ion-icon>

Fixes: # Add tag img:

  • action-sheet.wp.scss and action-sheet.md.scss
    `.action-sheet-md .action-sheet-img {
    @include padding(0);
    @include text-align($action-sheet-md-img-text-align);

    width: $action-sheet-md-img-width;

    font-size: $action-sheet-md-img-font-size;
    vertical-align: $action-sheet-md-img-vertical-align;

    @include deprecated-variable(margin, $action-sheet-md-img-margin) {
    @include margin($action-sheet-md-img-margin-top, $action-sheet-md-img-margin-end, $action-sheet-md-img-margin-bottom, $action-sheet-md-img-margin-start);
    }
    }`

  • action-sheet-options.ts
    export interface ActionSheetButton { text?: string; role?: string; icon?: string; img?: string; cssClass?: string; handler?: () => boolean|void; }

  • action-sheet-controller.ts and action-sheet-component.ts
    <img [src]="b.img" *ngIf="b.img" class="action-sheet-img">

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant