This repository was archived by the owner on May 4, 2022. It is now read-only.
fix(AlertComponent): check if d.buttons and d.inputs is defined#936
Open
KillerCodeMonkey wants to merge 1 commit intoionic-team:masterfrom
Open
fix(AlertComponent): check if d.buttons and d.inputs is defined#936KillerCodeMonkey wants to merge 1 commit intoionic-team:masterfrom
KillerCodeMonkey wants to merge 1 commit intoionic-team:masterfrom
Conversation
Make sure buttons and inputs are defined. At least as empty array. Only add them to the template, if they are defined and habe at least one entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure buttons and inputs are defined. At least as empty array.
Only add them to the template, if they are defined and habe at least one entry.
Short description of what this resolves:
the definition of
d.buttonsandd.inputsis not safe inside of the alert component.Changes proposed in this pull request:
ionViewDidLoadFixes:
This is one issue if you run angular template checks.
e.g. if you run
ngcwithin your
tsconfig.jsonErrors: