Conversation
|
Hi, are you interested in this patch? If not I can remove... |
gyurix
left a comment
gyurix
left a comment
There was a problem hiding this comment.
Reasonable bug report, patch is too blunt.
#if defined(TIME_UTC) && !defined(__ANDROID__) fixes one Android toolchain case by disabling timespec_get() on all Android targets. That can become wrong again as NDK/API availability changes.
Merge readiness: 5/10. Before merge: gate on actual function availability / API level instead of platform-wide __ANDROID__, or at least document tested Android NDK range.
|
After some serach it seems |
|
I'm sorry but since I very rarely make pull requests (so I'm not very expert), I don't understand if I merged the right patch or not. Can you check? |
2 participants
Android NDK define TIME_UTC but doesn't have the timespec_get() function than the compilation fails. This patch add a flag to check if the compilation is on Android.