JSON-formatted '/status' API response + generic cleanup #3038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The /status API call can now return usable JSON data
Owner
Author
|
@sdargoeuves @captainpacket -- here's the API implementation of "netlab status" as a usable data structure. I also did a bit of a cleanup, hopefully resulting in a more generic "get" method that can handle multiple multi-part requests. I wanted to retain the "old" /status results in case anyone already uses them, so you get the JSON data structure back only with "/status/json" or "/status/json/instance". I would love to have a better idea how to handle that. Any suggestions? |
There was a problem hiding this comment.
Pull request overview
This PR adds JSON-formatted responses to the /status API endpoint and refactors the API request handler routing logic for better maintainability.
Changes:
- Added generic
send_replyandsend_errorhelper functions for consistent response handling - Enhanced
/statusendpoint to support JSON output and instance-specific queries - Refactored GET request routing to use separate handler dictionaries for simple and path-based endpoints
- Updated default bind address to use
external_commands.get_local_addr()instead of hardcoded localhost - Added KeyboardInterrupt handling and improved server startup logging with protocol information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The /status API call can now return usable JSON data