Skip to content

add singelton class #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Emelie1812 wants to merge 1 commit into from
Closed

add singelton class #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/main/java/com/example/Singelton.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
package com.example;

public class Singelton {
}
Comment on lines +3 to +4
Copy link

@coderabbitai coderabbitai bot Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

This doesn't implement the Singleton pattern.

The class is named "Singelton" (typo: should be "Singleton") and the PR claims to add a singleton, but this implementation lacks the essential components of the Singleton design pattern:

  • No private constructor to prevent direct instantiation
  • No private static instance field
  • No public static getInstance() method

As written, this class can be instantiated multiple times with new Singelton(), which defeats the purpose of a singleton.

Apply this diff to implement a proper thread-safe Singleton pattern:

-public class Singelton {
+public class Singleton {
+    private static Singleton instance;
+    
+    private Singleton() {
+        // Private constructor prevents instantiation
+    }
+    
+    public static synchronized Singleton getInstance() {
+        if (instance == null) {
+            instance = new Singleton();
+        }
+        return instance;
+    }
 }

Alternatively, for a simpler eager initialization approach:

-public class Singelton {
+public class Singleton {
+    private static final Singleton INSTANCE = new Singleton();
+    
+    private Singleton() {
+        // Private constructor prevents instantiation
+    }
+    
+    public static Singleton getInstance() {
+        return INSTANCE;
+    }
 }

Do you want me to help implement the Singleton pattern properly, or would you like guidance on which approach best fits your use case?

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
public class Singelton {
}
public class Singleton {
private static Singleton instance;
private Singleton() {
// Private constructor prevents instantiation
}
public static synchronized Singleton getInstance() {
if (instance == null) {
instance = new Singleton();
}
return instance;
}
}
Suggested change
public class Singelton {
}
public class Singleton {
private static final Singleton INSTANCE = new Singleton();
private Singleton() {
// Private constructor prevents instantiation
}
public static Singleton getInstance() {
return INSTANCE;
}
}
🤖 Prompt for AI Agents 
In src/main/java/com/example/Singelton.java around lines 3-4, the class is
misspelled and does not implement the Singleton pattern; rename the class and
file to Singleton, add a private constructor to prevent external instantiation,
add a private static instance field, and provide a public static getInstance()
method; implement either eager initialization (private static final Singleton
INSTANCE = new Singleton(); public static Singleton getInstance() { return
INSTANCE; }) or a thread-safe lazy initialization (private static volatile
Singleton instance; public static Singleton getInstance() { if (instance ==
null) synchronized(Singleton.class) { if (instance == null) instance = new
Singleton(); } return instance; }) and update references/imports accordingly.

Loading