Skip to content

Revert "Tests"#33

Merged
AseelHamamreh merged 1 commit intomainfrom
revert-32-tests
Nov 16, 2025
Merged

Revert "Tests"#33
AseelHamamreh merged 1 commit intomainfrom
revert-32-tests

Conversation

@AseelHamamreh
Copy link
Contributor

@AseelHamamreh AseelHamamreh commented Nov 16, 2025

Summary by CodeRabbit

  • Removed Features

    • Removed chat messaging functionality including message composition and display capabilities.
    • Removed real-time message receiving feature.
  • Changes

    • Application title updated from "Chat App" to "Hello MVC".
    • User interface updated to reflect new application purpose.

@AseelHamamreh AseelHamamreh merged commit daa1037 into main Nov 16, 2025
1 of 2 checks passed
@coderabbitai
Copy link

coderabbitai bot commented Nov 16, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This PR removes the chat feature implementation, including the ChatController and ChatModel classes, chat-view.fxml UI file, related tests, and HTTP dependencies. The application configuration reverts to hello-view.fxml with title "Hello MVC", and Maven plugin configurations are removed.

Changes

Cohort / File(s) Summary
Chat Feature Removal
src/main/java/com/example/ChatController.java, src/main/java/com/example/ChatModel.java, src/main/resources/com/example/chat-view.fxml
Deleted ChatController class with UI bindings and message handling logic, ChatModel class with HTTP client and SSE-based messaging, and associated BorderPane/ListView/TextField FXML layout.
Application Entry Point
src/main/java/com/example/HelloFX.java
Changed FXML resource from chat-view.fxml to hello-view.fxml and updated window title from "Chat App" to "Hello MVC".
Module Configuration
src/main/java/module-info.java
Removed requires java.net.http; module dependency.
Build Configuration
pom.xml
Removed maven-compiler-plugin (Java 25 release/source/target settings) and maven-surefire-plugin configuration blocks.
Test Removal
src/test/java/com/example/ChatModelTest.java
Deleted entire JUnit 5 test class that validated ChatModel's parseMessage, sendMessage, and subscribe functionality.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • The changes are straightforward deletions following consistent patterns across multiple file types
  • Primary concern: verify no remaining code references the deleted ChatController, ChatModel classes, or removed module dependency
  • Confirm hello-view.fxml resource exists to replace the removed chat-view.fxml reference

Possibly related PRs

  • PR #27: Directly inverse—added ChatModel, ChatController, chat-view.fxml, java.net.http module requirement, and related wiring that this PR removes.
  • PR #32: Directly inverse—added ChatModel, ChatController, chat-view.fxml, Maven plugin configurations, and java.net.http module requirement that this PR removes.

Poem

🐰 A chat once lived, now fades away,
Controller gone, model's had its day,
FXML files return to rest,
Hello returns—simplicity's best! 🌱

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert-32-tests

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fcd0249 and dce624d.

📒 Files selected for processing (7)
  • pom.xml (1 hunks)
  • src/main/java/com/example/ChatController.java (0 hunks)
  • src/main/java/com/example/ChatModel.java (0 hunks)
  • src/main/java/com/example/HelloFX.java (1 hunks)
  • src/main/java/module-info.java (0 hunks)
  • src/main/resources/com/example/chat-view.fxml (0 hunks)
  • src/test/java/com/example/ChatModelTest.java (0 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

This was referenced Nov 17, 2025
@kappsegla kappsegla deleted the revert-32-tests branch November 19, 2025 18:32
@coderabbitai coderabbitai bot mentioned this pull request Nov 20, 2025
@coderabbitai coderabbitai bot mentioned this pull request Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant