Fix UTurn encoding/decoding failing#43
Open
DavidKarlas wants to merge 1 commit into
Open
Conversation
I noticed that sometimes UTurn decoding throws exception that happens because the way `NetworkTile.TurnCosts.cs` encodes `prefixEdge` EdgeId. If it is from different tile it does `(int)-(prefixEdge.LocalId + 1)`, but under some conditions this can overflow and resulting `int` is not negative. So when decoding it checks `if (signedLocalId >= 0)` and wrongly assume edge is from same tile, and does not read TileId, resulting in wrong decoding of turncost table size. It felt like just cutting MaxLocalId in half as easier solution that might solve more problems like this in future. Wondering if cache version should be increased?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that sometimes UTurn decoding throws exception that happens because the way
NetworkTile.TurnCosts.csencodesprefixEdgeEdgeId. If it is from different tile it does(int)-(prefixEdge.LocalId + 1), but under some conditions this can overflow and resultingintis not negative. So when decoding it checksif (signedLocalId >= 0)and wrongly assume edge is from same tile, and does not read TileId, resulting in wrong decoding of turncost table size.It felt like just cutting MaxLocalId in half as easier solution that might solve more problems like this in future. Wondering if cache version should be increased?