Add http_client_options for per-provider HTTP timeout/proxy/verify#31
Merged
Conversation
Forwards the league/oauth2-client-whitelisted Guzzle options (timeout, proxy, verify) through bundle configuration. Closes the long-standing inability to bound HTTP requests to the IdP. Additive only — existing config continues to work unchanged. README adds a short note explaining why the stack uses Guzzle rather than Symfony HttpClient (league/oauth2-client hard-types its httpClient as GuzzleHttp\ClientInterface). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #31 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 56 57 +1
===========================================
Files 9 9
Lines 248 268 +20
===========================================
+ Hits 248 268 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 tasks
jekuaitk
requested changes
May 7, 2026
Comment on lines
+140
to
+141
| // Block must either be absent or empty so nothing leaks into Guzzle. | ||
| $this->assertSame([], $providerOptions['http_client_options'] ?? []); |
Collaborator
There was a problem hiding this comment.
If i understand the code modifications correctly this should never be empty but always absent.
Contributor
Author
There was a problem hiding this comment.
Changed assert, added comment
Comment on lines
+137
to
+138
| Only the keys whitelisted by `league/oauth2-client` are forwarded: `timeout`, | ||
| `proxy`, and `verify` (the last only when `proxy` is set). |
Collaborator
There was a problem hiding this comment.
I read this as: non-whitelisted keys are stripped. But, according to testHttpClientOptionsRejectsUnknownKey the configurations actually throws an error. Am i misunderstanding?
Contributor
Author
There was a problem hiding this comment.
Attempted to clairy
Drop the `?? []` fallback that masked the difference between an absent key and an empty array. Per the schema (no defaultValue on the arrayNode), an omitted input must produce no key at all. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The previous wording read as if league silently strips non-whitelisted keys. The bundle config rejects them up front with InvalidConfigurationException at container compile time. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jekuaitk
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
http_client_optionsblock (timeout,proxy,verify) forwarded to the underlying Guzzle HTTP client used by league/oauth2-clienthttpClientasGuzzleHttp\ClientInterface)Backward compatibility
Additive only. No existing config keys, signatures, defaults, or dependencies change. Targets the next minor (4.2.0).
Test plan
task test— 51 tests passtask analyze:php— phpstan max level, no errorstask lint— php-cs-fixer, composer normalize, markdown, yaml all cleantask test:matrix— all 6 combinations (PHP 8.3/8.4/8.5 × prefer-lowest/prefer-stable) passhttp_client_options.timeout: 0.001and verify aConnectExceptionfires rather than a long hang🤖 Generated with Claude Code