Update to C++23 and fix const iterator bug#4
Merged
iwatakeshi merged 5 commits intomasterfrom Dec 9, 2025
Merged
Conversation
Co-authored-by: iwatakeshi <1505448+iwatakeshi@users.noreply.github.com>
Co-authored-by: iwatakeshi <1505448+iwatakeshi@users.noreply.github.com>
Co-authored-by: iwatakeshi <1505448+iwatakeshi@users.noreply.github.com>
Co-authored-by: iwatakeshi <1505448+iwatakeshi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update project to latest C++ version and ensure tests pass
Update to C++23 and fix const iterator bug
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates project to C++23 standard and fixes iterator consistency bug.
Changes
const_iterator end()missing offset calculation, making it inconsistent with non-const versionNative C++ Feature Review
Codebase already uses modern C++ extensively: concepts, ranges, three-way comparison, smart pointers, move semantics. Optional future enhancements:
std::ranges::fold_left(C++23) for reduce operationsfmt::formattostd::format(though fmt often preferred)No immediate replacements needed—the custom array intentionally provides JavaScript/Python-like API (push/pop/shift/unshift/slice/join) not found in standard containers.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.